Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix workbench routes to support modal mounting #401

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Conversation

ps48
Copy link
Member

@ps48 ps48 commented Oct 11, 2024

Description

Fix workbench routes to support modal mounting

Issues Resolved

  • Fixes modal load for workbench via dev tools modal.
workbench-modal-checks.mov
  • Persists flint non-MDS navigation flows
flint-workbench-url-check.mov

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ps48 ps48 merged commit 8190b1f into main Oct 11, 2024
14 of 20 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 11, 2024
Signed-off-by: Shenoy Pratik <[email protected]>
(cherry picked from commit 8190b1f)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ps48 pushed a commit that referenced this pull request Oct 11, 2024
(cherry picked from commit 8190b1f)

Signed-off-by: Shenoy Pratik <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants