Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]added error handling for api calls #408

Merged
merged 2 commits into from
Oct 22, 2024

Conversation

sumukhswamy
Copy link
Collaborator

@sumukhswamy sumukhswamy commented Oct 21, 2024

Description

r MDS plugins needed error handling to not return response as okay

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

server/routes/query.ts Outdated Show resolved Hide resolved
Signed-off-by: sumukhswamy <[email protected]>
@sumukhswamy sumukhswamy merged commit 853597b into opensearch-project:main Oct 22, 2024
7 of 11 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 22, 2024
* [Bug]added error handling for api calls

Signed-off-by: sumukhswamy <[email protected]>

* linter fix

Signed-off-by: sumukhswamy <[email protected]>

---------

Signed-off-by: sumukhswamy <[email protected]>
(cherry picked from commit 853597b)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ps48 pushed a commit that referenced this pull request Oct 22, 2024
* [Bug]added error handling for api calls



* linter fix



---------


(cherry picked from commit 853597b)

Signed-off-by: sumukhswamy <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants