Use smaller and compressed varients of buttons and form components #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miki <[email protected]>
Signed-off-by: Miki <[email protected]>
Signed-off-by: Miki <[email protected]>
Signed-off-by: Miki <[email protected]>
Signed-off-by: Miki <[email protected]>
Signed-off-by: Miki <[email protected]>
Signed-off-by: Miki <[email protected]>
Signed-off-by: Miki <[email protected]>
Signed-off-by: Miki <[email protected]>
Signed-off-by: Miki <[email protected]>
AMoo-Miki
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsi-amazon,
Swiddis,
penghuo,
seankao-az and
anirudha
as code owners
AMoo-Miki
changed the title
AMoo-Miki
changed the title
derek-ho
reviewed
Aug 2, 2024
| @@ -14,7 +14,7 @@ import { | |||
| EuiFlexGroup, | |||
| EuiFlexItem, | |||
| EuiLoadingSpinner, | |||
| EuiButton, | |||
There was a problem hiding this comment.
Should this just be removed, seems not used?
derek-ho
reviewed
Aug 2, 2024
derek-ho
approved these changes
Aug 2, 2024
|
Looks like snapshots need to be updated as well |
derek-ho
approved these changes
Aug 2, 2024
Signed-off-by: Miki <[email protected]>
|
The failing tests are due to changes that will be coming in OUI 1.9.0. Let's leave this open and try retry when OSD gets updated to OUI 1.9.0. |
…(#7637) * Bump OUI to 1.9.0 Signed-off-by: Miki <[email protected]> * Introduce the redesigned page header Signed-off-by: Miki <[email protected]> Update UX of breadcrumbs, menu toggle, and the new contribution points Signed-off-by: Miki <[email protected]> Add renderElement option in HeaderControls Signed-off-by: Shenoy Pratik <[email protected]> Update application mocks and rearrange header layout Signed-off-by: Shenoy Pratik <[email protected]> Break and restyle breadcrumb Signed-off-by: Zhongnan Su <[email protected]> Implement header updates Signed-off-by: Miki <[email protected]> * Introduce HeaderVariant Signed-off-by: Miki <[email protected]> * Organize Header's layout Signed-off-by: Miki <[email protected]> * Fix header control spacing Signed-off-by: Miki <[email protected]> * Conditionally append breadcrumb to recent popover Fix mock for recent items Co-authored-by: Zhongnan Su <[email protected]> Co-authored-by: Shenoy Pratik <[email protected]> * Update top nav render and add app header Use ScreenTitle instead of appname from topnav menu Signed-off-by: Shenoy Pratik <[email protected]> * Compress QueryStringInput appearance Signed-off-by: Miki <[email protected]> * Update header for applications Signed-off-by: Miki <[email protected]> * Eliminate colors from the borders of grouped action menu items Signed-off-by: Miki <[email protected]> * Update TopNavControl*Data type to controlType for consistency Signed-off-by: Miki <[email protected]> * Add tests for chrome Header Signed-off-by: Shenoy Pratik <[email protected]> * Update Breadcrumbs tests Signed-off-by: Shenoy Pratik <[email protected]> * Add tests for HeaderControlsContainer Signed-off-by: Miki <[email protected]> * Add tests for TopNavControls and TopNavControlItem Signed-off-by: Shenoy Pratik <[email protected]> * Updated tests for TopNavMenu and TopNavMenuItem Signed-off-by: Shenoy Pratik <[email protected]> * Fix `uiSettingsServiceMock` missing `start` Signed-off-by: Miki <[email protected]> * Add the `target` property to TopNavControlItem Signed-off-by: Miki <[email protected]> * Update Navigation mock and start contract Signed-off-by: Miki <[email protected]> * Add createGetterSetter mock in dashboards app state Signed-off-by: Shenoy Pratik <[email protected]> * Add tests for setting and unsetting header variant Signed-off-by: Miki <[email protected]> * Add tests for setting header controls Signed-off-by: Miki <[email protected]> * Re-skin DataSource selection's trigger button Signed-off-by: Miki <[email protected]> * Conditionally change where theme management menu item shows up Signed-off-by: Miki <[email protected]> * Conditionally change where the help menu items shows up Signed-off-by: Miki <[email protected]> * Make IndexPatternTable page conditionally use the new page header Signed-off-by: Miki <[email protected]> * Make Discover conditionally use the new application header Signed-off-by: Miki <[email protected]> * Make Dashboards conditionally use the new application header Signed-off-by: Miki <[email protected]> * Add changelog fragment Signed-off-by: Shenoy Pratik <[email protected]> Signed-off-by: Miki <[email protected]> * Add tracking issue for empty label for DataSourceMenuPopoverButton Signed-off-by: Miki <[email protected]> * Use EUI aliases in CSS variables Signed-off-by: Miki <[email protected]> * Remove TopNavMenuLink Signed-off-by: Miki <[email protected]> * Make sure OuiHeader doesn't contribute to the background Also: * Remove unused code Signed-off-by: Miki <[email protected]> * Better border hiding for DSM popover button Signed-off-by: Miki <[email protected]> * Make popover button overflow later Signed-off-by: Miki <[email protected]> --------- Signed-off-by: Miki <[email protected]> Signed-off-by: Shenoy Pratik <[email protected]> Co-authored-by: Zhongnan Su <[email protected]> Co-authored-by: Shenoy Pratik <[email protected]> (cherry picked from commit 265a176390f337ddc2f3cc20dcd367e77b9abd9f) Signed-off-by: Miki <[email protected]>
Signed-off-by: Miki <[email protected]>
|
OUI 1.9 was merged into main and the only failures are for to linting issues unrelated to this PR. |
mengweieric
approved these changes
Aug 19, 2024
joshuali925
approved these changes
Aug 19, 2024
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-reporting/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/dashboards-reporting/backport-2.x
# Create a new branch
git switch --create backport/backport-398-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ff37ada3bedcc9bb1d9235436c6a3e301aaacaa8
# Push it to GitHub
git push --set-upstream origin backport/backport-398-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-reporting/backport-2.xThen, create a pull request where the |
joshuali925
pushed a commit
to joshuali925/dashboards-reporting
that referenced
this pull request
Aug 19, 2024
…pensearch-project#398) Signed-off-by: Miki <[email protected]> Signed-off-by: Shenoy Pratik <[email protected]> Co-authored-by: Zhongnan Su <[email protected]> Co-authored-by: Shenoy Pratik <[email protected]>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace instances of
EuiButtonthat don't have an explicit sizing attribute toEuiSmallButton*.Replace instances of
Eui<form elements>that don't have density attributes toEuiCompressed<form elements>.Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.