Force DOCUMENT replication on lock index #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Widdis <[email protected]>
dbwiddis
requested review from
joshpalis,
saratvemulapalli,
kaituo and
vibrantvarun
as code owners
Signed-off-by: Daniel Widdis <[email protected]>
Signed-off-by: Daniel Widdis <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #417 +/- ##
=========================================
Coverage 28.77% 28.77%
Complexity 97 97
=========================================
Files 22 22
Lines 1178 1178
Branches 109 109
=========================================
Hits 339 339
Misses 818 818
Partials 21 21 |
vibrantvarun
approved these changes
Jul 10, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 10, 2023
* Force DOCUMENT replication on lock index Signed-off-by: Daniel Widdis <[email protected]> * Test releasing lock to avoid any query cache issues Signed-off-by: Daniel Widdis <[email protected]> * Restore original test config Signed-off-by: Daniel Widdis <[email protected]> --------- Signed-off-by: Daniel Widdis <[email protected]> (cherry picked from commit 877b425)
joshpalis
pushed a commit
that referenced
this pull request
Jul 10, 2023
* Force DOCUMENT replication on lock index Signed-off-by: Daniel Widdis <[email protected]> * Test releasing lock to avoid any query cache issues Signed-off-by: Daniel Widdis <[email protected]> * Restore original test config Signed-off-by: Daniel Widdis <[email protected]> --------- Signed-off-by: Daniel Widdis <[email protected]> (cherry picked from commit 877b425) Co-authored-by: Daniel Widdis <[email protected]>
kaituo
added a commit
to kaituo/anomaly-detection-1
that referenced
this pull request
Jul 11, 2023
In this PR, we temporarily enforce DOCUMENT replication for AD indices. This change is necessary due to the current limitation of SegRep, which doesn't support Get/MultiGet by ID. This measure will be in place until SegRep adds support for these operations. This adjustment aligns with the modification made in the referenced PR: opensearch-project/job-scheduler#417 Signed-off-by: Kaituo Li <[email protected]>
kaituo
added a commit
to opensearch-project/anomaly-detection
that referenced
this pull request
Jul 11, 2023
In this PR, we temporarily enforce DOCUMENT replication for AD indices. This change is necessary due to the current limitation of SegRep, which doesn't support Get/MultiGet by ID. This measure will be in place until SegRep adds support for these operations. This adjustment aligns with the modification made in the referenced PR: opensearch-project/job-scheduler#417 Signed-off-by: Kaituo Li <[email protected]>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
In support of #407
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.