-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix remote model with embedding input issue #3289
Open
b4sjoo
wants to merge
5
commits into
opensearch-project:main
Choose a base branch
from
b4sjoo:main_interfacefix
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+53
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: b4sjoo <[email protected]>
b4sjoo
added
bug
Something isn't working
backport 2.x
backport 2.16
backport 2.17
backport 2.18
labels
Dec 18, 2024
b4sjoo
requested review from
dhrubo-os,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
Zhangxunmt,
austintlee,
HenryL27 and
xinyual
as code owners
December 18, 2024 10:07
b4sjoo
had a problem deploying
to
ml-commons-cicd-env
December 18, 2024 10:07 — with
GitHub Actions
Failure
b4sjoo
temporarily deployed
to
ml-commons-cicd-env
December 18, 2024 10:07 — with
GitHub Actions
Inactive
b4sjoo
temporarily deployed
to
ml-commons-cicd-env
December 18, 2024 11:04 — with
GitHub Actions
Inactive
|
Signed-off-by: b4sjoo <[email protected]>
b4sjoo
had a problem deploying
to
ml-commons-cicd-env
December 19, 2024 10:45 — with
GitHub Actions
Failure
b4sjoo
had a problem deploying
to
ml-commons-cicd-env
December 19, 2024 10:45 — with
GitHub Actions
Failure
Signed-off-by: b4sjoo <[email protected]>
b4sjoo
temporarily deployed
to
ml-commons-cicd-env
December 19, 2024 10:46 — with
GitHub Actions
Inactive
b4sjoo
had a problem deploying
to
ml-commons-cicd-env
December 19, 2024 10:46 — with
GitHub Actions
Failure
UT added. |
b4sjoo
temporarily deployed
to
ml-commons-cicd-env
December 19, 2024 12:19 — with
GitHub Actions
Inactive
b4sjoo
had a problem deploying
to
ml-commons-cicd-env
December 19, 2024 13:17 — with
GitHub Actions
Failure
jngz-es
previously approved these changes
Dec 19, 2024
ylwu-amzn
reviewed
Dec 19, 2024
plugin/src/test/java/org/opensearch/ml/utils/MLNodeUtilsTests.java
Outdated
Show resolved
Hide resolved
…chema Signed-off-by: b4sjoo <[email protected]>
b4sjoo
had a problem deploying
to
ml-commons-cicd-env
December 20, 2024 13:11 — with
GitHub Actions
Failure
b4sjoo
had a problem deploying
to
ml-commons-cicd-env
December 20, 2024 13:11 — with
GitHub Actions
Failure
ylwu-amzn
reviewed
Dec 20, 2024
plugin/src/test/java/org/opensearch/ml/utils/MLNodeUtilsTests.java
Outdated
Show resolved
Hide resolved
Signed-off-by: b4sjoo <[email protected]>
b4sjoo
temporarily deployed
to
ml-commons-cicd-env
December 20, 2024 19:30 — with
GitHub Actions
Inactive
b4sjoo
temporarily deployed
to
ml-commons-cicd-env
December 20, 2024 19:30 — with
GitHub Actions
Inactive
b4sjoo
temporarily deployed
to
ml-commons-cicd-env
December 20, 2024 20:27 — with
GitHub Actions
Inactive
ylwu-amzn
approved these changes
Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
All remote embedding model will throw exception when use embedding input instead of remote input. However Neural Search uses a hardcoded value
FunctionName.TEXT_EMBEDDING
when instantiating theMLInput
:https://github.com/opensearch-project/neural-search/blob/7feacd67b3c7694ff4a1c1c2b430f2447a1ed4ab/src/main/java/org/opensearch/neuralsearch/ml/MLCommonsClientAccessor.java#L293
Therefore, we removed the required string
parameter
in input interface to enable the dual usage of remote model. In the future, we plan to use different interface on different usage in same connector as a long term fix.Related Issues
Resolves #3261
Check List
--signoff
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.