Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump guava version to 32.1.3 #3300

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

junqiu-lei
Copy link
Member

@junqiu-lei junqiu-lei commented Dec 27, 2024

Description

Bump guava version to 32.1.3 to resolve version conflicts in neural search plugin to compile ml-commons plugin.

| Caused by: java.lang.IllegalStateException: jar hell!
| class: com.google.common.annotations.Beta
| jar1: /local/home/junqiu/dev/neural-search/build/testclusters/integTest-0/distro/3.0.0-ARCHIVE/plugins/opensearch-ml/guava-32.1.2-jre.jar
| jar2: /local/home/junqiu/dev/neural-search/build/testclusters/integTest-0/distro/3.0.0-ARCHIVE/plugins/opensearch-knn/guava-32.1.3-jre.jar
|       at org.opensearch.bootstrap.JarHell.checkClass(JarHell.java:316)
|       at org.opensearch.bootstrap.JarHell.checkJarHell(JarHell.java:215)
|       at org.opensearch.plugins.PluginsService.checkBundleJarHell(PluginsService.java:675)
|       ... 11 more

Related Issues

opensearch-project/neural-search#480

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@jngz-es
Copy link
Collaborator

jngz-es commented Dec 27, 2024

Thanks @junqiu-lei , could you also help bump the version in ml-algorithms,

implementation group: 'com.google.guava', name: 'guava', version: '32.1.2-jre'
?

@dhrubo-os
Copy link
Collaborator

Thanks @junqiu-lei , could you also help bump the version in ml-algorithms,

implementation group: 'com.google.guava', name: 'guava', version: '32.1.2-jre'

?

+1

@junqiu-lei junqiu-lei temporarily deployed to ml-commons-cicd-env-require-approval December 27, 2024 20:39 — with GitHub Actions Inactive
@junqiu-lei junqiu-lei temporarily deployed to ml-commons-cicd-env-require-approval December 27, 2024 20:52 — with GitHub Actions Inactive
@junqiu-lei junqiu-lei had a problem deploying to ml-commons-cicd-env-require-approval December 27, 2024 20:52 — with GitHub Actions Failure
@junqiu-lei
Copy link
Member Author

Thanks @junqiu-lei , could you also help bump the version in ml-algorithms,

implementation group: 'com.google.guava', name: 'guava', version: '32.1.2-jre'

?

Yes, just updated PR.

@junqiu-lei junqiu-lei deployed to ml-commons-cicd-env-require-approval December 27, 2024 21:36 — with GitHub Actions Active
@junqiu-lei junqiu-lei requested a deployment to ml-commons-cicd-env-require-approval December 27, 2024 23:31 — with GitHub Actions Waiting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants