Fix random total hits range for ExplanationPayloadProcessorTests. #1034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bo Zhang <[email protected]>
bzhangam
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski,
sean-zheng-amazon,
model-collapse,
zane-neo,
vibrantvarun,
zhichao-aws,
yuye-aws and
minalsha
as code owners
heemin32
approved these changes
Dec 18, 2024
heemin32
added
the
backport 2.x
martin-gaievski
approved these changes
Dec 18, 2024
martin-gaievski
merged commit 22ba5d3
into
opensearch-project:main
57 of 58 checks passed
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 18, 2024
) Signed-off-by: Bo Zhang <[email protected]> (cherry picked from commit 22ba5d3)
martin-gaievski
pushed a commit
that referenced
this pull request
Dec 19, 2024
) (#1036) Signed-off-by: Bo Zhang <[email protected]> (cherry picked from commit 22ba5d3) Co-authored-by: Bo Zhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix random total hits range for ExplanationPayloadProcessorTests. In tests we don't expect 0 total hit and 0 total hit will cause Index 0 out of bounds for length 0 error because we assume it should not be 0.
Related Issues
N/A
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.