Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make endpoint_string one line for ccr test #4794

Merged

Conversation

peterzhuamazon
Copy link
Member

@peterzhuamazon peterzhuamazon commented Jun 20, 2024

Description

Make endpoint_string one line for ccr test

On Windows, it could not able to handle multi-line parameters well like on *nix system through bash.exe.

Therefore, we will group the entire json into one line.

https://ci.opensearch.org/ci/dbc/integ-test/2.15.0/9992/windows/x64/zip/test-results/[…]nteg-test/cross-cluster-replication/with-security/stderr.txt

https://ci.opensearch.org/ci/dbc/integ-test/2.15.0/9992/windows/x64/zip/test-results/[…]nteg-test/cross-cluster-replication/with-security/stdout.txt

https://build.ci.opensearch.org/blue/rest/organizations/jenkins/pipelines/integ-test/runs/8299/nodes/112/steps/500/log/?start=0

Thanks.

Issues Resolved

#4681
opensearch-project/cross-cluster-replication#1395

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@peterzhuamazon
Copy link
Member Author

Copy link

codecov bot commented Jun 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.05%. Comparing base (a5a3d6d) to head (a94e293).
Report is 13 commits behind head on main.

Files Patch % Lines
...workflow/integ_test/integ_test_suite_opensearch.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4794   +/-   ##
=======================================
  Coverage   92.05%   92.05%           
=======================================
  Files         193      193           
  Lines        6416     6416           
=======================================
  Hits         5906     5906           
  Misses        510      510           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peterzhuamazon peterzhuamazon merged commit af2f02c into opensearch-project:main Jun 20, 2024
12 of 13 checks passed
@peterzhuamazon peterzhuamazon deleted the ccr-singleline-json branch June 20, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants