Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add similarity settings when using CreateIndexRequest #989

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ritty27
Copy link

@ritty27 ritty27 commented May 16, 2024

Description

This PR Partial resolution #987
There are several types of Similarity, so I only made some of the representative ones (BM25, Boolean).
Therefore, the code does not implement all similarity(DFI, DFR, IB etc.).
If the this commit is okay, I will try to implement other types similarly.

Issues Resolved

#987

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dblock
Copy link
Member

dblock commented May 16, 2024

Looks good to me, needs tests, documentation, samples, etc.

Take a look at https://github.com/opensearch-project/opensearch-api-specification too. I think we want to derive a lot of this code from spec (@Xtansia is working on a generator #366).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants