Remove the dual write option for request/response (tuple) output

Signed-off-by: Brian Presley <[email protected]>

TrafficCapture/trafficReplayer/src/main/java/org/opensearch/migrations/replay/SourceTargetCaptureTuple.java

@@ -12,7 +12,6 @@
 import org.opensearch.migrations.replay.datatypes.UniqueSourceRequestKey;
 
 import java.io.IOException;
-import java.io.OutputStream;
 import java.io.SequenceInputStream;
 import java.nio.charset.StandardCharsets;
 import java.time.Duration;
@@ -55,11 +54,9 @@ public void close() {
     }
 
     public static class TupleToFileWriter implements Consumer<SourceTargetCaptureTuple> {
-        OutputStream outputStream;
         Logger tupleLogger = LogManager.getLogger("OutputTupleJsonLogger");
 
-        public TupleToFileWriter(OutputStream outputStream){
-            this.outputStream = outputStream;
+        public TupleToFileWriter(){
         }
 
         private JSONObject jsonFromHttpDataUnsafe(List<byte[]> data) throws IOException {
@@ -169,8 +166,6 @@ public void accept(SourceTargetCaptureTuple triple) {
             JSONObject jsonObject = toJSONObject(triple);
 
             tupleLogger.info(jsonObject.toString());
-            outputStream.write((jsonObject.toString()+"\n").getBytes(StandardCharsets.UTF_8));
-            outputStream.flush();
         }
     }
 

TrafficCapture/trafficReplayer/src/main/java/org/opensearch/migrations/replay/TrafficReplayer.java

@@ -36,11 +36,8 @@
 import software.amazon.awssdk.regions.Region;
 
 import javax.net.ssl.SSLException;
-import java.io.BufferedOutputStream;
 import java.io.EOFException;
-import java.io.FileOutputStream;
 import java.io.IOException;
-import java.io.OutputStream;
 import java.lang.ref.WeakReference;
 import java.net.URI;
 import java.time.Duration;
@@ -224,12 +221,6 @@ static class Parameters {
                 arity=1,
                 description = "input file to read the request/response traces for the source cluster")
         String inputFilename;
-        @Parameter(required = false,
-                names = {"-o", "--output"},
-                arity=1,
-                description = "output file to hold the request/response traces for the source and target cluster")
-        String outputFilename;
-
         @Parameter(required = false,
                 names = {"-t", PACKET_TIMEOUT_SECONDS_PARAMETER_NAME},
                 arity = 1,
@@ -325,17 +316,15 @@ public static void main(String[] args)
             return;
         }
 
-        try (OutputStream outputStream = params.outputFilename == null ? System.out :
-                new FileOutputStream(params.outputFilename, true);
-             var bufferedOutputStream = new BufferedOutputStream(outputStream);
+        try (
              var blockingTrafficStream = TrafficCaptureSourceFactory.createTrafficCaptureSource(params,
                      Duration.ofSeconds(params.lookaheadTimeSeconds));
              var authTransformer = buildAuthTransformerFactory(params))
         {
             var tr = new TrafficReplayer(uri, params.transformerConfig, authTransformer,
                     params.allowInsecureConnections, params.numClientThreads,  params.maxConcurrentRequests);
             setupShutdownHookForReplayer(tr);
-            var tupleWriter = new SourceTargetCaptureTuple.TupleToFileWriter(bufferedOutputStream);
+            var tupleWriter = new SourceTargetCaptureTuple.TupleToFileWriter();
             var timeShifter = new TimeShifter(params.speedupFactor);
             tr.setupRunAndWaitForReplayWithShutdownChecks(Duration.ofSeconds(params.observedPacketConnectionTimeout),
                     blockingTrafficStream, timeShifter, tupleWriter);