Skip to content

Commit

Permalink
Address PR Comments
Browse files Browse the repository at this point in the history
Signed-off-by: Andre Kurait <[email protected]>
  • Loading branch information
AndreKurait committed Sep 6, 2024
1 parent d40e53b commit 670b999
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 3 deletions.
3 changes: 2 additions & 1 deletion .github/workflows/CI.yml
Original file line number Diff line number Diff line change
Expand Up @@ -112,12 +112,13 @@ jobs:
with:
name: test-reports
path: |
**/build/reports/tests/
**/reports/jacoco/mergedReport/
- name: Upload to Codecov
uses: codecov/codecov-action@v4
with:
file: "./build/reports/jacoco/mergedReport/jacocoMergedReport.xml"
files: ${{ github.workspace }}/build/reports/jacoco/mergedReport/jacocoMergedReport.xml
flags: gradle-test
fail_ci_if_error: true
disable_search: true
Expand Down
13 changes: 13 additions & 0 deletions TrafficCapture/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -32,3 +32,16 @@ allprojects {
}
}
}

tasks.named('test', Test) {
// Memory leak tests are adding too much execution time on `test` in TrafficCapture
// Disabling and will test in `slowTest`
systemProperty 'disableMemoryLeakTests', 'true'
}

tasks.named('slowTest', Test) {
useJUnitPlatform {
// Ensure rerunning all tests to run with leak detection
includeTags = []
}
}
2 changes: 0 additions & 2 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,6 @@ subprojects {
showStackTraces true
showStandardStreams = true
}
systemProperty 'disableMemoryLeakTests', 'true'

// Provide way to exclude particular tests from CLI
// e.g. ../gradlew test -PexcludeTests=**/KafkaProtobufConsumerLongTermTest*
Expand Down Expand Up @@ -99,7 +98,6 @@ subprojects {
useJUnitPlatform {
includeTags 'longTest'
}
systemProperty 'disableMemoryLeakTests', 'false'
jacoco.enabled = true
}

Expand Down

0 comments on commit 670b999

Please sign in to comment.