Minor cleanup/addressing PR feedback.

Signed-off-by: Greg Schohn <[email protected]>
opensearch-project · Aug 29, 2023 · 8d2313f · 8d2313f
1 parent fb7dccd
commit 8d2313f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 10 deletions.
diff --git a/...rc/main/java/org/opensearch/migrations/replay/PacketToTransformingHttpHandlerFactory.java b/...rc/main/java/org/opensearch/migrations/replay/PacketToTransformingHttpHandlerFactory.java
@@ -17,7 +17,6 @@
 import org.opensearch.migrations.replay.util.StringTrackableCompletableFuture;
 
 import java.net.URI;
-import java.util.Arrays;
 import java.util.concurrent.CompletableFuture;
 import java.util.concurrent.ExecutionException;
 import java.util.concurrent.atomic.AtomicInteger;
@@ -59,11 +58,6 @@ public ChannelFuture load(final String s) {
         });
     }
 
-    NettyPacketToHttpConsumer createNettyHandler(String diagnosticLabel) {
-        return new NettyPacketToHttpConsumer(eventLoopGroup, serverUri, sslContext, diagnosticLabel);
-    }
-
-
     public int getNumConnectionsCreated() {
         return numConnectionsCreated.get();
     }
@@ -88,7 +82,7 @@ public DiagnosticTrackableCompletableFuture<String,Void> stopGroup() {
             try {
                 var channelClosedFuturesArray =
                         connectionId2ChannelCache.asMap().values().stream()
-                                .map(this::closeChannel)
+                                .map(this::closeClientConnectionChannel)
                                 .collect(Collectors.toList());
                 StringTrackableCompletableFuture.<Channel>allOf(channelClosedFuturesArray.stream(),
                         () -> "all channels closed")
@@ -141,13 +135,13 @@ public void closeConnection(String connId) {
         log.atDebug().setMessage(()->"closing connection for " + connId).log();
         var channelsFuture = connectionId2ChannelCache.getIfPresent(connId);
         if (channelsFuture != null) {
-            closeChannel(channelsFuture);
+            closeClientConnectionChannel(channelsFuture);
             connectionId2ChannelCache.invalidate(connId);
         }
     }
 
     private DiagnosticTrackableCompletableFuture<String, Channel>
-    closeChannel(ChannelFuture channelsFuture) {
+    closeClientConnectionChannel(ChannelFuture channelsFuture) {
         var channelClosedFuture =
                 new StringTrackableCompletableFuture<>(new CompletableFuture<Channel>(),
                         ()->"Waiting for closeFuture() on channel");

diff --git a/TrafficCapture/trafficReplayer/src/test/resources/log4j2.properties b/TrafficCapture/trafficReplayer/src/test/resources/log4j2.properties
@@ -1,7 +1,7 @@
 status = error 
 
 # Root logger options
-rootLogger.level = info
+rootLogger.level = debug
 rootLogger.appenderRef.console.ref = Console
 
 # Console appender configuration