Upgrade protobuf version #1005
Upgrade protobuf version #1005
Conversation
Signed-off-by: Tanner Lewis <[email protected]>
lewijacn
requested review from
AndreKurait,
chelma,
gregschohn,
mikaylathompson,
okhasawn,
peternied and
sumobrian
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1005 +/- ##
============================================
- Coverage 80.17% 80.13% -0.05%
+ Complexity 2721 2718 -3
============================================
Files 370 370
Lines 13622 13624 +2
Branches 938 938
============================================
- Hits 10921 10917 -4
- Misses 2130 2134 +4
- Partials 571 573 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @@ -9,11 +9,11 @@ plugins { | |||
|
|
|||
| dependencies { | |||
| api project(":commonDependencyVersionConstraints") | |||
| api group: 'com.google.protobuf', name: 'protobuf-java', version: '3.22.2' | |||
| api group: 'com.google.protobuf', name: 'protobuf-java', version: '3.25.5' | |||
There was a problem hiding this comment.
Can we remove the version from here?
There was a problem hiding this comment.
Let me test, I am also curious about this
| } | ||
|
|
||
| protobuf { | ||
| protoc { | ||
| artifact = "com.google.protobuf:protoc:3.22.2" | ||
| artifact = "com.google.protobuf:protoc:3.25.5" |
There was a problem hiding this comment.
Can we try removing the version from here? I'm less sure about this one
There was a problem hiding this comment.
If you remove one of these, we really should remove the other too. I want the version specifiers to be specified together in the same file.
Signed-off-by: Tanner Lewis <[email protected]>
Description
Current protobuf version has a risk that can be remediated by upgrading to latest version: https://ossindex.sonatype.org/component/pkg:maven/com.google.protobuf/[email protected]
3.22.2 -> 3.25.5
Issues Resolved
N/A
Is this a backport? If so, please add backport PR # and/or commits #
Testing
[Please provide details of testing done: unit testing, integration testing and manual testing]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.