Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed greedy matching from a regex to address DOS concern. #1006

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

chelma
Copy link
Member

@chelma chelma commented Sep 24, 2024

Description

  • Per the title, removing some greedy matching to mitigate DOS concern

Issues Resolved

Testing

  • Ran the existing unit tests

Check List

  • New functionality includes testing
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.17%. Comparing base (92bee7f) to head (77f8ab6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1006      +/-   ##
============================================
+ Coverage     80.16%   80.17%   +0.01%     
- Complexity     2720     2721       +1     
============================================
  Files           370      370              
  Lines         13624    13624              
  Branches        938      938              
============================================
+ Hits          10921    10923       +2     
+ Misses         2131     2130       -1     
+ Partials        572      571       -1     
Flag Coverage Δ
gradle-test 78.18% <100.00%> (+0.01%) ⬆️
python-test 89.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chelma chelma merged commit 2107ccb into opensearch-project:main Sep 24, 2024
14 checks passed
@chelma chelma deleted the regex branch September 24, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants