Include AWS Solution cloud formation template #1101
+6,125
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1101 +/- ##
============================================
- Coverage 80.66% 80.65% -0.01%
- Complexity 2893 2904 +11
============================================
Files 383 384 +1
Lines 14361 14358 -3
Branches 989 989
============================================
- Hits 11584 11581 -3
+ Misses 2184 2183 -1
- Partials 593 594 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>
peternied
requested review from
AndreKurait,
chelma,
gregschohn,
lewijacn,
mikaylathompson and
sumobrian
as code owners
lewijacn
reviewed
Oct 24, 2024
| @@ -188,11 +188,17 @@ jobs: | |||
| docker stop $(docker ps -q) && docker system prune --volumes -f | |||
| docker image ls --format '{{.Repository}}:{{.Tag}}' | grep '^migrations/' | xargs -I {} docker image rm {} | |||
|
|
|||
| cdk-tests: | |||
| node-tests: | |||
| init: CloudFormationInit.fromElements(...cfnInitConfig), | ||
| initOptions: { | ||
| printLog: true, | ||
| ignoreFailures: true, |
There was a problem hiding this comment.
This would mean any errors from our init script would not stop deployment? Trying to decide if this is a better experience or not for a user, what are your thoughts?
| bootstrapRole.addManagedPolicy(ManagedPolicy.fromAwsManagedPolicyName('AdministratorAccess')) | ||
|
|
||
| new InstanceProfile(this, 'BootstrapInstanceProfile', { | ||
| instanceProfileName: `bootstrap-${stageParameter.valueAsString}-instance-profile`, |
There was a problem hiding this comment.
To resolve this bug: https://opensearch.atlassian.net/browse/MIGRATIONS-2027, can you also include region in this name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The existing AWS Solutions template is in a GitHub repo GitHub - aws-solutions/migration-assistant-for-amazon-opensearch: Upgrade, Migrate, and Compare OpenSearch Clusters but isn’t used for performing updates.
With ongoing efforts to improve deployment speed, having the solutions deployment inside of the OpenSearch-Migration GitHub repo makes coordinating cross stack references easier and creates a clear workflow for contribution.
Issues Resolved
To Do Before Leaving Draft
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.