-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include AWS Solution cloud formation template #1101
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1101 +/- ##
============================================
- Coverage 80.66% 80.65% -0.01%
- Complexity 2893 2904 +11
============================================
Files 383 384 +1
Lines 14361 14358 -3
Branches 989 989
============================================
- Hits 11584 11581 -3
+ Misses 2184 2183 -1
- Partials 593 594 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was expecting a bin/ folder do you plan to use?
@@ -188,11 +188,17 @@ jobs: | |||
docker stop $(docker ps -q) && docker system prune --volumes -f | |||
docker image ls --format '{{.Repository}}:{{.Tag}}' | grep '^migrations/' | xargs -I {} docker image rm {} | |||
|
|||
cdk-tests: | |||
node-tests: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for including 👍
init: CloudFormationInit.fromElements(...cfnInitConfig), | ||
initOptions: { | ||
printLog: true, | ||
ignoreFailures: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would mean any errors from our init script would not stop deployment? Trying to decide if this is a better experience or not for a user, what are your thoughts?
bootstrapRole.addManagedPolicy(ManagedPolicy.fromAwsManagedPolicyName('AdministratorAccess')) | ||
|
||
new InstanceProfile(this, 'BootstrapInstanceProfile', { | ||
instanceProfileName: `bootstrap-${stageParameter.valueAsString}-instance-profile`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To resolve this bug: https://opensearch.atlassian.net/browse/MIGRATIONS-2027, can you also include region in this name
Description
The existing AWS Solutions template is in a GitHub repo GitHub - aws-solutions/migration-assistant-for-amazon-opensearch: Upgrade, Migrate, and Compare OpenSearch Clusters but isn’t used for performing updates.
With ongoing efforts to improve deployment speed, having the solutions deployment inside of the OpenSearch-Migration GitHub repo makes coordinating cross stack references easier and creates a clear workflow for contribution.
Issues Resolved
To Do Before Leaving Draft
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.