Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport: Sync devDeploy with recent Replayer auth changes (#279) #281

Conversation

lewijacn
Copy link
Collaborator

@lewijacn lewijacn commented Aug 22, 2023

Change has been verified with devDeploy to AWS

  • Sync devDeploy with recent Replayer auth changes

Signed-off-by: Tanner Lewis [email protected]
(cherry picked from commit 4165dc4)

Description

[Describe what this change achieves]

  • Category (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)
  • Why these changes are required?
  • What is the old behavior before changes and new behavior after changes?

Issues Resolved

[List any issues this PR will resolve]

Is this a backport? If so, please add backport PR # and/or commits #

Testing

[Please provide details of testing done: unit testing, integration testing and manual testing]

Check List

  • New functionality includes testing
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

)

* Sync devDeploy with recent Replayer auth changes

Signed-off-by: Tanner Lewis <[email protected]>
(cherry picked from commit 4165dc4)
@lewijacn lewijacn changed the title Sync devDeploy with recent Replayer auth changes (#279) Backport: Sync devDeploy with recent Replayer auth changes (#279) Aug 22, 2023
@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #281 (f5a5ac7) into capture-and-replay-v0.1.0 (0e2e704) will decrease coverage by 8.59%.
The diff coverage is n/a.

@@                       Coverage Diff                       @@
##             capture-and-replay-v0.1.0     #281      +/-   ##
===============================================================
- Coverage                        68.25%   59.66%   -8.59%     
  Complexity                         608      608              
===============================================================
  Files                              107       82      -25     
  Lines                             4284     3129    -1155     
  Branches                           414      292     -122     
===============================================================
- Hits                              2924     1867    -1057     
+ Misses                            1168     1085      -83     
+ Partials                           192      177      -15     
Flag Coverage Δ
unittests 59.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 25 files with indirect coverage changes

@lewijacn lewijacn merged commit 7706b40 into opensearch-project:capture-and-replay-v0.1.0 Aug 23, 2023
4 of 5 checks passed
@lewijacn lewijacn deleted the backport/backport-279-to-capture-and-replay-v0.1.0 branch March 29, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants