Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align Capture Proxy naming and Improve Migration Console UX #284

Merged
merged 4 commits into from
Aug 23, 2023

Conversation

lewijacn
Copy link
Collaborator

@lewijacn lewijacn commented Aug 23, 2023

Description

This change accomplishes a few small tasks to make UX a bit better

  1. Aligns the naming of the capture proxy and port to be the same for docker and Copilot, as well as updates related usages and documentation for this
  2. Gives the migration console console access to the target domain endpoint to make cluster checking a bit easier there
  3. Includes a convenience script on the migration console to check indices and documents on the source and target clusters with a single script

Issues Resolved

None

Testing

Manual deployment local and cloud testing

Check List

  • New functionality includes testing
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@sumobrian sumobrian changed the base branch from main to capture-and-replay-v0.1.0 August 23, 2023 17:34
@sumobrian sumobrian changed the base branch from capture-and-replay-v0.1.0 to main August 23, 2023 17:40
Copy link
Collaborator

@sumobrian sumobrian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sumobrian sumobrian merged commit f31a65c into opensearch-project:main Aug 23, 2023
3 of 4 checks passed
@opensearch-trigger-bot
Copy link

The backport to capture-and-replay-v0.1.0 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-capture-and-replay-v0.1.0 capture-and-replay-v0.1.0
# Navigate to the new working tree
pushd ../.worktrees/backport-capture-and-replay-v0.1.0
# Create a new branch
git switch --create backport/backport-284-to-capture-and-replay-v0.1.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 f31a65c60ec679cf1b6498741f8b93133ef20ff2
# Push it to GitHub
git push --set-upstream origin backport/backport-284-to-capture-and-replay-v0.1.0
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-capture-and-replay-v0.1.0

Then, create a pull request where the base branch is capture-and-replay-v0.1.0 and the compare/head branch is backport/backport-284-to-capture-and-replay-v0.1.0.

sumobrian added a commit that referenced this pull request Sep 11, 2023
Align Capture Proxy naming and Improve Migration Console UX

(cherry picked from commit f31a65c)
@lewijacn lewijacn deleted the add-endpoint-to-console branch March 29, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants