Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport #283 to capture-and-replay-v0.1.0 #291

Conversation

mikaylathompson
Copy link
Collaborator

Description

Backport of #283

Issues Resolved

Testing

[Please provide details of testing done: unit testing, integration testing and manual testing]

Check List

  • New functionality includes testing
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Merging #291 (491d4d4) into capture-and-replay-v0.1.0 (9221fe9) will decrease coverage by 0.04%.
The diff coverage is 18.75%.

@@                       Coverage Diff                       @@
##             capture-and-replay-v0.1.0     #291      +/-   ##
===============================================================
- Coverage                        59.78%   59.74%   -0.04%     
  Complexity                         609      609              
===============================================================
  Files                               82       82              
  Lines                             3138     3140       +2     
  Branches                           292      292              
===============================================================
  Hits                              1876     1876              
- Misses                            1085     1087       +2     
  Partials                           177      177              
Flag Coverage Δ
unittests 59.74% <18.75%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...ch/migrations/replay/SourceTargetCaptureTuple.java 0.00% <0.00%> (ø)
.../opensearch/migrations/replay/TrafficReplayer.java 6.75% <0.00%> (ø)
...y/datahandlers/http/NettyJsonToByteBufHandler.java 95.83% <100.00%> (ø)

Copy link
Collaborator

@sumobrian sumobrian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sumobrian sumobrian merged commit 3300eca into capture-and-replay-v0.1.0 Aug 30, 2023
6 of 8 checks passed
@github-actions github-actions bot deleted the backport/backport-283-to-capture-and-replay-v0.1.0 branch August 30, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants