Add test to run opensearch benchmark and compare doc counts #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Omar Khasawneh <[email protected]>
Signed-off-by: Omar Khasawneh <[email protected]>
okhasawn
requested review from
chelma,
gregschohn,
kartg,
lewijacn,
mikaylathompson and
sumobrian
as code owners
Codecov Report
@@ Coverage Diff @@
## main #369 +/- ##
============================================
- Coverage 63.64% 63.55% -0.10%
+ Complexity 718 715 -3
============================================
Files 82 82
Lines 3298 3298
Branches 303 303
============================================
- Hits 2099 2096 -3
- Misses 1011 1014 +3
Partials 188 188
Flags with carried forward coverage won't be shown. Click here to find out more. |
gregschohn
previously requested changes
Oct 25, 2023
Signed-off-by: Omar Khasawneh <[email protected]>
Signed-off-by: Omar Khasawneh <[email protected]>
Signed-off-by: Omar Khasawneh <[email protected]>
sumobrian
reviewed
Oct 25, 2023
test/tests.py
Outdated
| @@ -200,3 +221,37 @@ def test_0006_invalidIncorrectUri(self): | |||
| incorrectUri = "/_cluster/incorrectUri" | |||
| response = requests.get(f'{self.proxy_endpoint}{incorrectUri}', auth=self.auth, verify=False) | |||
| self.assertEqual(response.status_code, HTTPStatus.METHOD_NOT_ALLOWED) | |||
|
|
|||
| def test_0007_OSB(self): | |||
| cmd = "docker ps | grep 'migrations/migration_console:latest' | awk '{print $NF}'" | |||
There was a problem hiding this comment.
I recommend using docker ps --format="{{.ID}}" --filter name=migration-console and avoiding the pipes. This will give you the container ID.
Signed-off-by: Omar Khasawneh <[email protected]>
sumobrian
approved these changes
Nov 9, 2023
Signed-off-by: Omar Khasawneh <[email protected]>
Signed-off-by: Omar Khasawneh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a test to the E2E script where it runs Opensearch Benchmark on the solution then compares the document count on both source and target clusters
Issues Resolved
Migrations-1409
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.