Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse target client in doc reindexer #672

Merged

Conversation

peternied
Copy link
Member

Description

Small refactor for testability of document indexer actions, following from the snapshot test cases [1].

Check List

  • New functionality includes testing
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.45%. Comparing base (c8be42b) to head (24a9826).
Report is 9 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #672      +/-   ##
============================================
- Coverage     75.51%   75.45%   -0.07%     
+ Complexity     1422     1419       -3     
============================================
  Files           150      150              
  Lines          6147     6147              
  Branches        561      561              
============================================
- Hits           4642     4638       -4     
- Misses         1135     1139       +4     
  Partials        370      370              
Flag Coverage Δ
unittests 75.45% <ø> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@chelma chelma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peternied peternied merged commit 9279ac0 into opensearch-project:main May 24, 2024
6 of 7 checks passed
@peternied peternied deleted the rfs-reuse-target-client branch May 28, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants