Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameterize AWS Partition for GovCloud #674

Merged
merged 1 commit into from
May 22, 2024

Conversation

AndreKurait
Copy link
Member

Description

We need to parameterize the partition every time we use arn:aws in order to support other partitions (a.k.a. gov cloud)

  • Category: Enhancement
  • Why these changes are required? GovCloud Support
  • What is the old behavior before changes and new behavior after changes? CDK failed to deploy on gov cloud

Issues Resolved

MIGRATIONS-1737

Is this a backport? If so, please add backport PR # and/or commits #

Testing

Deployed to gov cloud

Check List

  • [ x] New functionality includes testing
    • [ x] All tests pass, including unit test, integration test and doctest
  • [ x] New functionality has been documented
  • [x ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.15%. Comparing base (ce707fe) to head (43fad85).
Report is 19 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #674      +/-   ##
============================================
- Coverage     75.27%   75.15%   -0.12%     
+ Complexity     1415     1413       -2     
============================================
  Files           150      150              
  Lines          6147     6147              
  Branches        561      561              
============================================
- Hits           4627     4620       -7     
- Misses         1146     1155       +9     
+ Partials        374      372       -2     
Flag Coverage Δ
unittests 75.15% <ø> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AndreKurait AndreKurait merged commit 40f9172 into opensearch-project:main May 22, 2024
7 of 8 checks passed
@AndreKurait AndreKurait deleted the GovCloudSupport branch May 22, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants