Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ALB and Target Cluster Proxy #685

Closed
wants to merge 18 commits into from

Conversation

AndreKurait
Copy link
Member

@AndreKurait AndreKurait commented May 24, 2024

Description

This change adds cdk functionality to define and deploy an ALB in front of the migration infrastructure that allows a customer to orchestrate a migration by modifying an alb listener.

  1. Adds a script create-acm-cert which generates and imports a long-lived alb compatible cert.
  2. Adds a custom resource which deploys a lambda and generates and imports an ACM cert
  3. Adds the ability to deploy a "target cluster proxy service" which is a non-capturing proxy that forwards requests to the deployed target cluster.
  4. Adds the ALB with a specified ACM cert arn, and adds a listener on port 29200 for the target proxy and 443 for the source proxy.
  5. Modifies the capture-proxy stack to deploy with https enabled by default
  6. Updates the minimum aws-cdk version to 2.117.0 in order to support FIPS alb security policies
  • Category: New Feature
  • Why these changes are required? Support zero-downtime migration
  • What is the old behavior before changes and new behavior after changes? Only change to existing deployments is the capture proxy in https

Issues Resolved

MIGRATIONS-1770

Is this a backport? If so, please add backport PR # and/or commits #

Testing

Manual testing in both gov cloud and commercial regions

Check List

  • New functionality includes testing
    • [x ] All tests pass, including unit test, integration test and doctest
  • [x ] New functionality has been documented
  • [x ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented May 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.40%. Comparing base (16c735b) to head (609393d).
Report is 1 commits behind head on main.

Current head 609393d differs from pull request most recent head c86425b

Please upload reports for the commit c86425b to get more accurate results.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #685      +/-   ##
============================================
+ Coverage     63.29%   63.40%   +0.10%     
- Complexity     1579     1582       +3     
============================================
  Files           220      220              
  Lines          9156     9156              
  Branches        793      793              
============================================
+ Hits           5795     5805      +10     
+ Misses         2950     2941       -9     
+ Partials        411      410       -1     
Flag Coverage Δ
unittests 63.40% <ø> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant