Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker image caching for Gradle github actions workflow #716

Conversation

mikaylathompson
Copy link
Collaborator

Description

This PR follows #698, which added docker image caching for the e2e tests pipeline. That has had a few days of bake time and has been working well, so this adds it to the gradle build and test workflow.

As mentioned in the JIRA task, one important consideration is that the cache key for this workflow is the same as for the e2e tests so that the cache can be shared. This is pretty straightforward because both workflows have the same first few steps, so I'm using exactly the same caching step and have verified that the results are the same (see my testing PR below).

Issues Resolved

MIGRATION-1766

Testing

Manual, including in mikaylathompson#2

Check List

  • New functionality includes testing
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Jun 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.29%. Comparing base (669f0f9) to head (16c735b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #716      +/-   ##
============================================
+ Coverage     63.24%   63.29%   +0.04%     
- Complexity     1578     1579       +1     
============================================
  Files           220      220              
  Lines          9156     9156              
  Branches        793      793              
============================================
+ Hits           5791     5795       +4     
+ Misses         2956     2950       -6     
- Partials        409      411       +2     
Flag Coverage Δ
unittests 63.29% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peternied peternied merged commit 254d847 into opensearch-project:main Jun 11, 2024
7 checks passed
@mikaylathompson mikaylathompson deleted the add-docker-cache-to-gradle-tests branch June 25, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants