-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collection of RFS tweaks and fixes #743
Conversation
Signed-off-by: Chris Helma <[email protected]>
Signed-off-by: Chris Helma <[email protected]>
Signed-off-by: Chris Helma <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #743 +/- ##
============================================
+ Coverage 63.89% 64.51% +0.62%
- Complexity 1584 1585 +1
============================================
Files 223 239 +16
Lines 9092 9918 +826
Branches 771 771
============================================
+ Hits 5809 6399 +590
- Misses 2874 3108 +234
- Partials 409 411 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took a look earlier at how we build images and what it would take to do it, since I only had about 10 minutes, I put a PR together that's based off of another branch that I was currently working out of. However, all the changes that are necessary should be in this one commit. That would also eliminate the need (pretty sure) to do any CDK change to pickup a new service name or classname.
This PR undoes part of the PR from a couple days ago that was approved to break the DocumentsFromSnapshotMigration project out of the RFS package, setting up the RFS package to a common jar, and not a source of any specific applications.
If you want to revert the earlier work, please do NOT rename RfsMigrateDocuments.java at the moment. It will be much harder to manage merge conflicts and the history, which is changing considerably at this point in time.
@chelma this PR seems out of date, still want to merge parts of it or close it out? |
Irrelevant at this point; closing |
Description
Issues Resolved
https://opensearch.atlassian.net/browse/MIGRATIONS-1748
Testing
./gradlew CreateSnapshot:run
,./gradlew MetadataMigration:run
,./gradlew DocumentsFromSnapshotMigration:run
) against the 7.10 Docker Compose setupCheck List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.