-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Console] Scale for ECS services; replayer start/stop #765
[Console] Scale for ECS services; replayer start/stop #765
Conversation
Signed-off-by: Mikayla Thompson <[email protected]>
Signed-off-by: Mikayla Thompson <[email protected]>
Signed-off-by: Mikayla Thompson <[email protected]>
Signed-off-by: Mikayla Thompson <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #765 +/- ##
============================================
+ Coverage 68.46% 68.48% +0.01%
+ Complexity 1577 1576 -1
============================================
Files 273 275 +2
Lines 11454 11587 +133
Branches 734 734
============================================
+ Hits 7842 7935 +93
- Misses 3209 3249 +40
Partials 403 403
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Mikayla Thompson <[email protected]>
6f08034
to
6cb5905
Compare
...ockerSolution/src/main/docker/migrationConsole/lib/console_link/console_link/logic/replay.py
Show resolved
Hide resolved
ReplayStatus = Enum("ReplayStatus", ["NOT_STARTED", "RUNNING", "STOPPED", "FAILED"]) | ||
|
||
|
||
class Replayer(ABC): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice way to inject this abstraction
Signed-off-by: Mikayla Thompson <[email protected]>
deployment/cdk/opensearch-service-migration/test/migration-console-stack.test.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Mikayla Thompson <[email protected]>
Signed-off-by: Mikayla Thompson <[email protected]>
Signed-off-by: Mikayla Thompson <[email protected]>
Signed-off-by: Mikayla Thompson <[email protected]>
Signed-off-by: Mikayla Thompson <[email protected]>
f6da3bc
into
opensearch-project:main
Description
Issues Resolved
Kind of a lot of them, because of how I broke down the replayer work:
https://opensearch.atlassian.net/browse/MIGRATIONS-1773
https://opensearch.atlassian.net/browse/MIGRATIONS-1774
https://opensearch.atlassian.net/browse/MIGRATIONS-1775
(these will truly be completed when the documentation is in place)
Testing
Unit tests, manually tested on ECS deployment
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.