-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic TransformationRule: IndexMappingTypeRemoval #783
Merged
peternied
merged 51 commits into
opensearch-project:main
from
peternied:transformer-min
Jul 10, 2024
Merged
Basic TransformationRule: IndexMappingTypeRemoval #783
peternied
merged 51 commits into
opensearch-project:main
from
peternied:transformer-min
Jul 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>
…l_of_types Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>
gregschohn
reviewed
Jul 1, 2024
DocumentsFromSnapshotMigration/src/main/java/com/rfs/RfsMigrateDocuments.java
Outdated
Show resolved
Hide resolved
RFS/src/main/java/com/rfs/transformers/Transformer_ES_6_8_to_OS_2_11.java
Show resolved
Hide resolved
RFS/src/main/java/com/rfs/version_es_6_8/IndexMetadataData_ES_6_8.java
Outdated
Show resolved
Hide resolved
coreUtilities/src/main/java/org/opensearch/migrations/transformation/entity/Index.java
Outdated
Show resolved
Hide resolved
...es/src/main/java/org/opensearch/migrations/transformation/rules/IndexMappingTypeRemoval.java
Outdated
Show resolved
Hide resolved
...es/src/main/java/org/opensearch/migrations/transformation/rules/IndexMappingTypeRemoval.java
Outdated
Show resolved
Hide resolved
...es/src/main/java/org/opensearch/migrations/transformation/rules/IndexMappingTypeRemoval.java
Outdated
Show resolved
Hide resolved
chelma
requested changes
Jul 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, I like where things are going. Had some comments/questions though. Thanks!
RFS/src/main/java/com/rfs/transformers/Transformer_ES_6_8_to_OS_2_11.java
Show resolved
Hide resolved
RFS/src/main/java/com/rfs/transformers/Transformer_ES_6_8_to_OS_2_11.java
Outdated
Show resolved
Hide resolved
RFS/src/main/java/com/rfs/transformers/Transformer_ES_6_8_to_OS_2_11.java
Show resolved
Hide resolved
RFS/src/main/java/com/rfs/transformers/Transformer_ES_6_8_to_OS_2_11.java
Show resolved
Hide resolved
...es/src/main/java/org/opensearch/migrations/transformation/rules/IndexMappingTypeRemoval.java
Outdated
Show resolved
Hide resolved
...es/src/main/java/org/opensearch/migrations/transformation/rules/IndexMappingTypeRemoval.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>
chelma
reviewed
Jul 3, 2024
RFS/src/main/java/com/rfs/transformers/Transformer_ES_6_8_to_OS_2_11.java
Show resolved
Hide resolved
RFS/src/main/java/com/rfs/transformers/Transformer_ES_6_8_to_OS_2_11.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>
chelma
reviewed
Jul 8, 2024
RFS/src/main/java/com/rfs/transformers/Transformer_ES_6_8_to_OS_2_11.java
Outdated
Show resolved
Hide resolved
RFS/src/main/java/com/rfs/transformers/Transformer_ES_6_8_to_OS_2_11.java
Show resolved
Hide resolved
Signed-off-by: Peter Nied <[email protected]>
…e test Signed-off-by: Peter Nied <[email protected]>
…her version updates looks like a bad version container doesn't start Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>
Missing ' RFS Dynamically selects transformer based on target cluster type', tracked with https://opensearch.atlassian.net/browse/MIGRATIONS-1827 Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>
Follow up issue https://opensearch.atlassian.net/browse/MIGRATIONS-1827 Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>
gregschohn
approved these changes
Jul 9, 2024
chelma
approved these changes
Jul 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all the work on this one!
Signed-off-by: Peter Nied <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding in a formal transformation rule into the codebase, these should be applicable with in RFS, TrafficCapture, or other systems by supporting the
Entity
interface on types that are supported. Created and wired up IndexMappingTypeRemoval into RFS.Note: This is a minimal building block for future metadata / transformation work; replayer support, refactoring existing transformations, version management, rules grouping, audit entries are out of scope for this pull request. There can be considerable investment in this space built off of this change.
Testing
Example test cases for the transformer and end to end test to support.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.