Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor Integ Test and Jenkins Improvements #797

Merged
merged 79 commits into from
Jul 9, 2024

Conversation

lewijacn
Copy link
Collaborator

@lewijacn lewijacn commented Jul 8, 2024

Description

  • Creates a vars folder at the root level for the Jenkins shared library. This is required to load the shared library dynamically and makes branch testing much easier.
  • Minor fixes from running integ_tests library

Issues Resolved

N/A

Is this a backport? If so, please add backport PR # and/or commits #

Testing

N/A

Check List

  • New functionality includes testing
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Tanner Lewis <[email protected]>
Signed-off-by: Tanner Lewis <[email protected]>
Signed-off-by: Tanner Lewis <[email protected]>
Signed-off-by: Tanner Lewis <[email protected]>
Signed-off-by: Tanner Lewis <[email protected]>
Signed-off-by: Tanner Lewis <[email protected]>
Signed-off-by: Tanner Lewis <[email protected]>
Signed-off-by: Tanner Lewis <[email protected]>
Signed-off-by: Tanner Lewis <[email protected]>
Signed-off-by: Tanner Lewis <[email protected]>
Signed-off-by: Tanner Lewis <[email protected]>
Signed-off-by: Tanner Lewis <[email protected]>
Signed-off-by: Tanner Lewis <[email protected]>
Signed-off-by: Tanner Lewis <[email protected]>
Signed-off-by: Tanner Lewis <[email protected]>
Signed-off-by: Tanner Lewis <[email protected]>
Signed-off-by: Tanner Lewis <[email protected]>
Signed-off-by: Tanner Lewis <[email protected]>
Signed-off-by: Tanner Lewis <[email protected]>
Signed-off-by: Tanner Lewis <[email protected]>
Signed-off-by: Tanner Lewis <[email protected]>
Signed-off-by: Tanner Lewis <[email protected]>
Signed-off-by: Tanner Lewis <[email protected]>
Signed-off-by: Tanner Lewis <[email protected]>
Signed-off-by: Tanner Lewis <[email protected]>
Signed-off-by: Tanner Lewis <[email protected]>
Copy link

codecov bot commented Jul 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.32%. Comparing base (25f857b) to head (0cb0893).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #797      +/-   ##
==========================================
+ Coverage   84.29%   84.32%   +0.02%     
==========================================
  Files          53       53              
  Lines        3484     3484              
==========================================
+ Hits         2937     2938       +1     
+ Misses        547      546       -1     
Flag Coverage Δ
python-test 84.32% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lewijacn lewijacn changed the title Improving Integ Tests Minor Integ Test and Jenkins Improvements Jul 9, 2024
@lewijacn lewijacn marked this pull request as ready for review July 9, 2024 15:55
Copy link
Member

@peternied peternied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should these be able to execute now? Can we update the CI workflow to exercise them?

@lewijacn
Copy link
Collaborator Author

lewijacn commented Jul 9, 2024

Should these be able to execute now? Can we update the CI workflow to exercise them?

We can execute them in our Jenkins pipelines, but our docker setup still doesn't have support for RFS or starting/stopping the Replayer

@lewijacn lewijacn merged commit a8630cb into opensearch-project:main Jul 9, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants