Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a node id to all spans #896
Add a node id to all spans #896
Changes from all commits
be81e7d
2e7f43b
3a72dc0
8847c03
fd9b306
8476607
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 88 in CreateSnapshot/src/main/java/com/rfs/CreateSnapshot.java
Codecov / codecov/patch
CreateSnapshot/src/main/java/com/rfs/CreateSnapshot.java#L87-L88
Check warning on line 172 in DocumentsFromSnapshotMigration/src/main/java/com/rfs/RfsMigrateDocuments.java
Codecov / codecov/patch
DocumentsFromSnapshotMigration/src/main/java/com/rfs/RfsMigrateDocuments.java#L170-L172
Check warning on line 185 in DocumentsFromSnapshotMigration/src/main/java/com/rfs/RfsMigrateDocuments.java
Codecov / codecov/patch
DocumentsFromSnapshotMigration/src/main/java/com/rfs/RfsMigrateDocuments.java#L185
Check warning on line 256 in DocumentsFromSnapshotMigration/src/main/java/com/rfs/RfsMigrateDocuments.java
Codecov / codecov/patch
DocumentsFromSnapshotMigration/src/main/java/com/rfs/RfsMigrateDocuments.java#L256
Check warning on line 31 in MetadataMigration/src/main/java/org/opensearch/migrations/MetadataMigration.java
Codecov / codecov/patch
MetadataMigration/src/main/java/org/opensearch/migrations/MetadataMigration.java#L30-L31
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets remove this overload to prevent null from leaking out
Check warning on line 227 in TrafficCapture/trafficReplayer/src/main/java/org/opensearch/migrations/replay/TrafficReplayer.java
Codecov / codecov/patch
TrafficCapture/trafficReplayer/src/main/java/org/opensearch/migrations/replay/TrafficReplayer.java#L225-L227
Check warning on line 264 in TrafficCapture/trafficReplayer/src/main/java/org/opensearch/migrations/replay/TrafficReplayer.java
Codecov / codecov/patch
TrafficCapture/trafficReplayer/src/main/java/org/opensearch/migrations/replay/TrafficReplayer.java#L264
Check warning on line 266 in TrafficCapture/trafficReplayer/src/main/java/org/opensearch/migrations/replay/TrafficReplayer.java
Codecov / codecov/patch
TrafficCapture/trafficReplayer/src/main/java/org/opensearch/migrations/replay/TrafficReplayer.java#L266