Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Console API] Add basic get status API #903

Merged
merged 11 commits into from
Aug 29, 2024

Conversation

lewijacn
Copy link
Collaborator

@lewijacn lewijacn commented Aug 15, 2024

Description

This change introduces a simple get status API to our Console API for retrieving the status of an OSI migration. This logic currently only returns the status and statusMessage from the OSI getPipeline API with the anticipation to add more details like progress in future iterations.

Also included is some reformatting of the response given by each of the API endpoints to keep a consistent response structure on error.

Issues Resolved

https://opensearch.atlassian.net/browse/MIGRATIONS-1945

Testing

Unit testing and manual cloud testing

Check List

  • New functionality includes testing
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Aug 15, 2024

Codecov Report

Attention: Patch coverage is 83.56164% with 12 lines in your changes missing coverage. Please review.

Project coverage is 74.54%. Comparing base (335fce8) to head (397a898).
Report is 96 commits behind head on main.

Files with missing lines Patch % Lines
...console_api/console_api/apps/orchestrator/views.py 67.56% 12 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #903      +/-   ##
============================================
- Coverage     74.93%   74.54%   -0.40%     
- Complexity     1933     1961      +28     
============================================
  Files           334      343       +9     
  Lines         13387    13607     +220     
  Branches        773      786      +13     
============================================
+ Hits          10032    10143     +111     
- Misses         2870     2977     +107     
- Partials        485      487       +2     
Flag Coverage Δ
gradle-test 68.99% <ø> (-0.50%) ⬇️
python-test 88.60% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sumobrian sumobrian self-requested a review August 29, 2024 20:05
Copy link
Collaborator

@sumobrian sumobrian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lewijacn lewijacn merged commit 617320a into opensearch-project:main Aug 29, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants