Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Migration Console API from ALB #924

Conversation

AndreKurait
Copy link
Member

@AndreKurait AndreKurait commented Sep 3, 2024

Description

Remove Migration Console API from ALB to simplify security story since this API is experimental and does not support auth.

  • Category: Simplification
  • Why these changes are required? Simplify Security
  • What is the old behavior before changes and new behavior after changes? No ALB Listener for Migration Console API, TG remains for customer to associate with their own listener.

Issues Resolved

MIGRATIONS-1971

Is this a backport? If so, please add backport PR # and/or commits #

Testing

Existing unit tests for cdk synth.

Check List

  • New functionality includes testing Experimental feature, no unit testing at the moment
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.13%. Comparing base (26a74b4) to head (7f03e52).
Report is 7 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #924      +/-   ##
============================================
- Coverage     74.51%   72.13%   -2.39%     
+ Complexity     1961     1870      -91     
============================================
  Files           343      346       +3     
  Lines         13555    13641      +86     
  Branches        786      786              
============================================
- Hits          10101     9840     -261     
- Misses         2964     3347     +383     
+ Partials        490      454      -36     
Flag Coverage Δ
gradle-test 65.65% <ø> (-3.35%) ⬇️
python-test 88.60% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AndreKurait AndreKurait force-pushed the RemoveMigrationConsoleAPIFromAlb branch from 21ed032 to 7f03e52 Compare September 3, 2024 18:04
Copy link
Collaborator

@lewijacn lewijacn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we still create the target group so I'm assuming guidance here is for users who want to use the API to create a listener on some ALB (potentially ours or maybe their own) and point it at our target group

@AndreKurait
Copy link
Member Author

LGTM, we still create the target group so I'm assuming guidance here is for users who want to use the API to create a listener on some ALB (potentially ours or maybe their own) and point it at our target group

Yes, that's correct

@AndreKurait AndreKurait merged commit f77bc1c into opensearch-project:main Sep 3, 2024
14 of 15 checks passed
@AndreKurait AndreKurait deleted the RemoveMigrationConsoleAPIFromAlb branch September 3, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants