Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken variable reference in traffic capture #925

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

peternied
Copy link
Member

Description

Fix broken variable reference in traffic capture

Check List

  • New functionality includes testing
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.12%. Comparing base (26a74b4) to head (f8c3225).
Report is 5 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #925      +/-   ##
============================================
- Coverage     74.51%   72.12%   -2.40%     
+ Complexity     1961     1869      -92     
============================================
  Files           343      346       +3     
  Lines         13555    13641      +86     
  Branches        786      786              
============================================
- Hits          10101     9839     -262     
- Misses         2964     3347     +383     
+ Partials        490      455      -35     
Flag Coverage Δ
gradle-test 65.64% <ø> (-3.36%) ⬇️
python-test 88.60% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peternied peternied merged commit 2fe3f36 into opensearch-project:main Sep 3, 2024
14 of 15 checks passed
@peternied peternied deleted the fix-log4j-log-dir branch September 3, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants