-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dashboards sanitizer #930
Dashboards sanitizer #930
Conversation
Signed-off-by: Arun Lakshmanan <[email protected]>
Signed-off-by: Arun Lakshmanan <[email protected]>
Signed-off-by: Milan Gyalai <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for iterating on this change great to see test cases included, I've got a couple of outstanding questions.
dashboardsSanitizer/src/test/resources/data/dashboard/input-001-version-8.8.0.json
Outdated
Show resolved
Hide resolved
Signed-off-by: Milan Gyalai <[email protected]>
Signed-off-by: Milan Gyalai <[email protected]>
Signed-off-by: Peter Nied <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gyalai-aws Thanks for the updates, it looks like there are some pull request checks that are failing, one for style check and another for compilation error. Please address these.
I've created a pull request [1] to make an update to the readme, please merge this into your branch as it has our messaging and guidance for experimental tools - congratulations on being the first.
Once the CI issue and readme updates have been completed, this can can be merged. Thanks!
Signed-off-by: Milan Gyalai <[email protected]>
Add experimental marker at the top of the readme
Description
[Describe what this change achieves]
This tool helps to migrate Kibana objects to OpenSearch dashboards object by fixing the versions for compatible objects and removing the object that are incompatible with OpenSearch Dashboards.
The Kibana object that are created after the fork are not compatible with OpenSearch Dashboards. To avoid recreating all the dashboards, this tool helps to fix the compatible objects.
Issues Resolved
[List any issues this PR will resolve]
Is this a backport? If so, please add backport PR # and/or commits #
Testing
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.