Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix extra args command parsing used by Metadata migration #931

Merged

Conversation

peternied
Copy link
Member

Description

Fix extra args command parsing used by Metadata migration

Testing

Added a new test case that validates all the end cases

Check List

  • New functionality includes testing
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

Attention: Patch coverage is 92.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 78.69%. Comparing base (d40e53b) to head (84cbe46).
Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
...e/lib/console_link/console_link/models/metadata.py 92.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #931      +/-   ##
============================================
+ Coverage     78.63%   78.69%   +0.06%     
+ Complexity     2365     2361       -4     
============================================
  Files           368      368              
  Lines         14223    14241      +18     
  Branches        827      827              
============================================
+ Hits          11184    11207      +23     
+ Misses         2523     2513      -10     
- Partials        516      521       +5     
Flag Coverage Δ
gradle-test 74.98% <ø> (+0.04%) ⬆️
python-test 88.63% <92.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Peter Nied <[email protected]>
@peternied peternied merged commit 1f9876d into opensearch-project:main Sep 9, 2024
15 checks passed
@peternied peternied deleted the metadata-extra-args-fixed branch September 9, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants