Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use builder for ShardMetadata #984

Closed

Conversation

AndreKurait
Copy link
Member

Description

Use builder for ShardMetadata

  • Category (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)
  • Why these changes are required?
  • What is the old behavior before changes and new behavior after changes?

Issues Resolved

[List any issues this PR will resolve]

Is this a backport? If so, please add backport PR # and/or commits #

Testing

[Please provide details of testing done: unit testing, integration testing and manual testing]

Check List

  • New functionality includes testing
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.40%. Comparing base (75171fb) to head (d77da84).
Report is 81 commits behind head on main.

Additional details and impacted files
@@              Coverage Diff              @@
##               main     #984       +/-   ##
=============================================
+ Coverage     80.90%   92.40%   +11.49%     
=============================================
  Files           402       70      -332     
  Lines         15582     4081    -11501     
  Branches        971        0      -971     
=============================================
- Hits          12607     3771     -8836     
+ Misses         2400      310     -2090     
+ Partials        575        0      -575     
Flag Coverage Δ
gradle-test ?
python-test 92.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Andre Kurait <[email protected]>
@AndreKurait
Copy link
Member Author

Written as a example implementation. Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant