Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete "datastash" which was a dockerfile to use logstash. #998

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

gregschohn
Copy link
Collaborator

Description

Delete "datastash" which was a dockerfile to use logstash. This isn't tested much and isn't something worth supporting at this point, now that snapshot reindexing is in place.

Testing

Just the CICD checks. I don't believe that this is used anywhere.

Check List

  • New functionality includes testing
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

This isn't tested much and isn't something worth supporting at this point, now that snapshot reindexing is in place.

Signed-off-by: Greg Schohn <[email protected]>
Copy link

codecov bot commented Sep 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.98%. Comparing base (d99beb6) to head (2834fbb).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #998   +/-   ##
=========================================
  Coverage     78.98%   78.98%           
  Complexity     2723     2723           
=========================================
  Files           375      375           
  Lines         13869    13869           
  Branches        970      970           
=========================================
  Hits          10955    10955           
  Misses         2340     2340           
  Partials        574      574           
Flag Coverage Δ
gradle-test 76.80% <ø> (ø)
python-test 89.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peternied peternied merged commit 1ffcec6 into opensearch-project:main Sep 23, 2024
14 checks passed
@gregschohn gregschohn deleted the DeleteDatastash branch September 23, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants