Fix CI Checks and upgrade actions/upload-artifact from v2 to v3 #580
+57
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Craig Perkins <[email protected]>
cwperks
requested review from
khushbr,
ansjcy,
sbcd90,
Shephalimittal,
nishchay21 and
rramachand21
as code owners
|
CI failures appear to be related to CentOS7 having archived the repositories in a vault: https://github.com/cloudspinx/centos7-vault-repositories https://www.redhat.com/en/blog/centos-linux-going-end-life-what-does-mean-me |
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #580 +/- ##
============================================
- Coverage 74.42% 74.39% -0.03%
Complexity 2665 2665
============================================
Files 317 317
Lines 16377 16377
Branches 1282 1282
============================================
- Hits 12188 12184 -4
- Misses 3674 3678 +4
Partials 515 515 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
|
Got the |
cwperks
changed the title
Signed-off-by: Craig Perkins <[email protected]>
|
Including changes from #579 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is your feature request related to a problem? Please provide an existing Issue # , or describe.
This PR does an upgrade of the actions/upload-artifact github action from v2 to v3 to resolve errors seen in CI checks like https://github.com/opensearch-project/performance-analyzer-rca/actions/runs/11485849764/job/31966863799?pr=577
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.