Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenSSLTest is not using the OpenSSL Provider #2219

Closed
wants to merge 1 commit into from

Conversation

reta
Copy link
Collaborator

@reta reta commented Nov 2, 2022

Signed-off-by: Andriy Redko [email protected]

Description

OpenSSLTest should be using the OpenSSL Provider. There are few issues with netty-tcnative and OpenSSL:

Issues Resolved

Closes #2208

Is this a backport? If so, please add backport PR # and/or commits #

Testing

[Please provide details of testing done: unit testing, integration testing and manual testing]

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov-commenter
Copy link

codecov-commenter commented Nov 2, 2022

Codecov Report

Merging #2219 (00c7a05) into main (89a11c5) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #2219      +/-   ##
============================================
- Coverage     61.06%   61.03%   -0.04%     
+ Complexity     3269     3268       -1     
============================================
  Files           259      259              
  Lines         18335    18335              
  Branches       3248     3248              
============================================
- Hits          11196    11190       -6     
- Misses         5553     5559       +6     
  Partials       1586     1586              
Impacted Files Coverage Δ
...ecurity/configuration/StaticResourceException.java 0.00% <0.00%> (-25.00%) ⬇️
...nsearch/security/dlic/rest/api/AuditApiAction.java 63.82% <0.00%> (-4.26%) ⬇️
...ic/auth/ldap/backend/LDAPAuthorizationBackend.java 57.73% <0.00%> (-0.57%) ⬇️
...ensearch/security/ssl/DefaultSecurityKeyStore.java 68.04% <0.00%> (+0.20%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@DarshitChanpura
Copy link
Member

Bwc tests are broken on main. Tracking issue here: #2221

@DarshitChanpura
Copy link
Member

Bwc tests are broken on main. Tracking issue here: #2221

@reta this should be unblocked now

@peternied
Copy link
Member

@reta Any thoughts on this PR? Seems like this work has stalled

@reta
Copy link
Collaborator Author

reta commented Dec 5, 2022

@reta Any thoughts on this PR? Seems like this work has stalled

@peternied I think we decided to drop support for OpenSSL (due to numerous limitations mentioned in description), the pull request in the current form will work only if OpenSSL 1.0.0 is present in the system (which is way outdated). The other options which some projects are doing is to prebuild netty-tcnative-openssl-static-{os_arch} binaries (since those are not available by default). WDYT?

@peternied
Copy link
Member

I'm going to close this pull request. If anything changes we can reopen in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] OpenSSLTest is not using the OpenSSL Provider
4 participants