Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build dep for byte-buddy #4127

Closed

Conversation

willyborankin
Copy link
Collaborator

@willyborankin willyborankin commented Mar 18, 2024

Description

Fix byte-buddy version for build. Due to conflict bvetween versions all new PRs fail with:

* What went wrong:
Execution failed for task ':integTestRemote'.
> Could not resolve all dependencies for configuration ':testRuntimeClasspath'.
   > Conflict found for the following module:
       - net.bytebuddy:byte-buddy between versions 1.14.9 and 1.14.7

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Fix byte-buddy version for build.

Signed-off-by: Andrey Pleskach <[email protected]>
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.94%. Comparing base (d526c9f) to head (8aef1df).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4127      +/-   ##
==========================================
+ Coverage   65.90%   65.94%   +0.03%     
==========================================
  Files         298      298              
  Lines       21352    21352              
  Branches     3475     3475              
==========================================
+ Hits        14073    14080       +7     
+ Misses       5540     5534       -6     
+ Partials     1739     1738       -1     

see 3 files with indirect coverage changes

@willyborankin
Copy link
Collaborator Author

The problem is related to core deps. The fix is here: opensearch-project/OpenSearch#12720. I'm closing this PR

@willyborankin
Copy link
Collaborator Author

Reopen it. If @reta's PR was merged it does not work since net.bytebuddy:byte-buddy is uses by io.dropwizard.metrics and io.dropwizard.metrics is used by OpenSAML.

@cwperks cwperks added the backport 2.x backport to 2.x branch label Mar 19, 2024
@reta
Copy link
Collaborator

reta commented Mar 19, 2024

@willyborankin so the build passes (at the moment, locally) with opensearch-project/OpenSearch#12720, does it fail on a particular pull request?

@willyborankin
Copy link
Collaborator Author

@cwperks lets wait it looks like @reta 1 hour ago merged the fix in the core. But I was thinking that fix in the core was merged yesterday, so maybe I'm wrong

@willyborankin
Copy link
Collaborator Author

false alarm :-)

@willyborankin willyborankin deleted the fix-build-deps branch June 14, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants