Fix onboarding skills repo issues #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zane-neo <[email protected]>
zane-neo
requested review from
b4sjoo,
dhrubo-os,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
Zhangxunmt,
xinyual,
amitgalitz,
jackiehanyang,
owaiskazi19,
ohltyler,
joshpalis,
dbwiddis,
kaituo,
lezzago,
eirsep,
sbcd90,
zhichao-aws and
joshuali925
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #156 +/- ##
=========================================
Coverage 81.73% 81.73%
Complexity 196 196
=========================================
Files 13 13
Lines 1002 1002
Branches 132 132
=========================================
Hits 819 819
Misses 133 133
Partials 50 50 ☔ View full report in Codecov by Sentry. |
Hailong-am
reviewed
Jan 30, 2024
| @@ -176,6 +176,7 @@ dependencyLicenses.enabled = false | |||
| loggerUsageCheck.enabled = false | |||
| testingConventions.enabled = false | |||
| thirdPartyAudit.enabled = false | |||
| publishNebulaPublicationToMavenLocal.enabled = false | |||
There was a problem hiding this comment.
why this task has been disabled?
There was a problem hiding this comment.
After changing the group to org.opensearch under allprojects, the publishToMavenLocal failed, the reason is this task found the two groupId not same: one is org.opensearch under allprojects, another is org.opensearch.plugin under publishing like below:
But we need to change group to org.opensearch under allprojects, to avoid publishing jar files to maven local based on EE team's ask. So we need to disable this task to by pass the error.
Hailong-am
approved these changes
Jan 30, 2024
xinyual
approved these changes
Jan 31, 2024
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/skills/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/skills/backport-2.x
# Create a new branch
git switch --create backport/backport-156-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e1aa8bf14172575779471280f21acaf5ec8829f9
# Push it to GitHub
git push --set-upstream origin backport/backport-156-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/skills/backport-2.xThen, create a pull request where the |
zane-neo
added a commit
to zane-neo/skills
that referenced
this pull request
Jan 31, 2024
Signed-off-by: zane-neo <[email protected]>
zane-neo
added a commit
to zane-neo/skills
that referenced
this pull request
Jan 31, 2024
Signed-off-by: zane-neo <[email protected]>
zane-neo
added a commit
that referenced
this pull request
Jan 31, 2024
* Fix onboarding skills repo issues (#156) Signed-off-by: zane-neo <[email protected]> * change publish workflow (#159) Signed-off-by: zane-neo <[email protected]> * Change jdk version Signed-off-by: zane-neo <[email protected]> --------- Signed-off-by: zane-neo <[email protected]>
zane-neo
added a commit
to zane-neo/skills
that referenced
this pull request
Mar 1, 2024
Signed-off-by: zane-neo <[email protected]>
yuye-aws
pushed a commit
to yuye-aws/skills
that referenced
this pull request
Apr 26, 2024
* Fix onboarding skills repo issues (opensearch-project#156) Signed-off-by: zane-neo <[email protected]> * change publish workflow (opensearch-project#159) Signed-off-by: zane-neo <[email protected]> * Change jdk version Signed-off-by: zane-neo <[email protected]> --------- Signed-off-by: zane-neo <[email protected]> Signed-off-by: yuye-aws <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix onboarding skills repo issues.
Issues Resolved
opensearch-project/opensearch-build#4378
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.