(PPLTool) update claude and openai prompts #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joshua Li <[email protected]>
joshuali925
requested review from
b4sjoo,
dhrubo-os,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
Zhangxunmt,
xinyual,
amitgalitz,
jackiehanyang,
owaiskazi19,
ohltyler,
joshpalis,
dbwiddis,
kaituo,
lezzago,
eirsep,
sbcd90 and
zhichao-aws
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #184 +/- ##
============================================
+ Coverage 81.76% 81.78% +0.01%
Complexity 201 201
============================================
Files 13 13
Lines 1042 1043 +1
Branches 139 139
============================================
+ Hits 852 853 +1
Misses 136 136
Partials 54 54 ☔ View full report in Codecov by Sentry. |
joshuali925
commented
Feb 6, 2024
xinyual
approved these changes
Feb 7, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 7, 2024
Signed-off-by: Joshua Li <[email protected]> (cherry picked from commit e001987) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
zane-neo
pushed a commit
that referenced
this pull request
Feb 7, 2024
(cherry picked from commit e001987) Signed-off-by: Joshua Li <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 15, 2024
Signed-off-by: Joshua Li <[email protected]> (cherry picked from commit e001987) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ylwu-amzn
pushed a commit
that referenced
this pull request
Feb 15, 2024
(cherry picked from commit e001987) Signed-off-by: Joshua Li <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
yuye-aws
pushed a commit
to yuye-aws/skills
that referenced
this pull request
Apr 26, 2024
…pensearch-project#192) (cherry picked from commit e001987) Signed-off-by: Joshua Li <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: yuye-aws <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The existing prompt for claude doesn't work, since it's using
%sas place holders. Additionally there were too many escapes.This PR fixes it and adds OpenAI prompt, which is the same as claude prompt except PPL in the examples are surrounded by
<ppl></ppl>tags. This prompt might get updated to tune performance later.Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.