-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed build for 2.12 #212
Fixed build for 2.12 #212
Conversation
Signed-off-by: owaiskazi19 <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #212 +/- ##
=========================================
Coverage 81.69% 81.69%
Complexity 206 206
=========================================
Files 13 13
Lines 1060 1060
Branches 141 141
=========================================
Hits 866 866
Misses 140 140
Partials 54 54 ☔ View full report in Codecov by Sentry. |
@prudhvigodithi can you take a look here? |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/skills/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/skills/backport-2.x
# Create a new branch
git switch --create backport/backport-212-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e852537f94df4a242046acb1d23517d94387fc57
# Push it to GitHub
git push --set-upstream origin backport/backport-212-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/skills/backport-2.x Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/skills/backport-2.12 2.12
# Navigate to the new working tree
pushd ../.worktrees/skills/backport-2.12
# Create a new branch
git switch --create backport/backport-212-to-2.12
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e852537f94df4a242046acb1d23517d94387fc57
# Push it to GitHub
git push --set-upstream origin backport/backport-212-to-2.12
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/skills/backport-2.12 Then, create a pull request where the |
Description
Fixed build for 2.12
Issues Resolved
Part of #178
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.