Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gradle task forbiddenApisMain failure #391

Merged
merged 2 commits into from
Aug 29, 2024

Conversation

zane-neo
Copy link
Collaborator

@zane-neo zane-neo commented Aug 28, 2024

Description

Fix gradle task forbiddenApisMain failure
Fix compilation failure caused by AD change

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.28%. Comparing base (2b76e3c) to head (6aec729).
Report is 33 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #391      +/-   ##
============================================
- Coverage     81.78%   81.28%   -0.51%     
- Complexity      193      246      +53     
============================================
  Files            11       14       +3     
  Lines           961     1261     +300     
  Branches        137      178      +41     
============================================
+ Hits            786     1025     +239     
- Misses          121      167      +46     
- Partials         54       69      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zane-neo zane-neo merged commit 3e63a62 into opensearch-project:main Aug 29, 2024
10 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/skills/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/skills/backport-2.x
# Create a new branch
git switch --create backport/backport-391-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 3e63a626029cc4d6fc64ca3143d14aefc7f3a27d
# Push it to GitHub
git push --set-upstream origin backport/backport-391-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/skills/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-391-to-2.x.

qianheng-aws pushed a commit to qianheng-aws/skills that referenced this pull request Nov 4, 2024
* Fix gradle task forbiddenApisMain failure

Signed-off-by: zane-neo <[email protected]>

* fix compilation error since AD change

Signed-off-by: zane-neo <[email protected]>

---------

Signed-off-by: zane-neo <[email protected]>

(cherry picked from commit 3e63a62)
Signed-off-by: Heng Qian <[email protected]>
zane-neo added a commit that referenced this pull request Nov 14, 2024
* add CreateAlertTool (#349)

* add CreateAlertTool

Signed-off-by: Heng Qian <[email protected]>

* spotlessApply and address comments

Signed-off-by: Heng Qian <[email protected]>

* add IT for CreateAlertTool

Signed-off-by: Heng Qian <[email protected]>

* address comments

Signed-off-by: Heng Qian <[email protected]>

* fix after merging main

Signed-off-by: Heng Qian <[email protected]>

* fix forbidden API

Signed-off-by: Heng Qian <[email protected]>

* fix IT failure

Signed-off-by: Heng Qian <[email protected]>

* run spotlessCheck

Signed-off-by: Heng Qian <[email protected]>

* Address comments

Signed-off-by: Heng Qian <[email protected]>

* Address comments of changing getIndex to use ActionListener

Signed-off-by: Heng Qian <[email protected]>

* fix IT

Signed-off-by: Heng Qian <[email protected]>

* make prompt dict static

Signed-off-by: Heng Qian <[email protected]>

---------

Signed-off-by: Heng Qian <[email protected]>

* Fix gradle task forbiddenApisMain failure (#391)

* Fix gradle task forbiddenApisMain failure

Signed-off-by: zane-neo <[email protected]>

* fix compilation error since AD change

Signed-off-by: zane-neo <[email protected]>

---------

Signed-off-by: zane-neo <[email protected]>

(cherry picked from commit 3e63a62)
Signed-off-by: Heng Qian <[email protected]>

---------

Signed-off-by: Heng Qian <[email protected]>
Signed-off-by: zane-neo <[email protected]>
Co-authored-by: zane-neo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants