Fix CreateAnomalyDetectorTool doesn't support data streams and alias #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: gaobinlong <[email protected]>
gaobinlong
requested review from
b4sjoo,
dhrubo-os,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
Zhangxunmt,
xinyual,
amitgalitz,
jackiehanyang,
owaiskazi19,
ohltyler,
joshpalis,
dbwiddis,
kaituo,
lezzago,
eirsep,
sbcd90,
zhichao-aws and
joshuali925
as code owners
xinyual
approved these changes
Oct 10, 2024
xinyual
requested changes
Oct 10, 2024
zane-neo
reviewed
Oct 10, 2024
Signed-off-by: gaobinlong <[email protected]>
Seems the failure relates to the issue of RAGToolIT is flaky, after retry now all checks have passed. |
xinyual
approved these changes
Oct 10, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 10, 2024
…423) * Fix CreateAnomalyDetectorTool doesn't support data streams and alias Signed-off-by: gaobinlong <[email protected]> * Refine the code comment Signed-off-by: gaobinlong <[email protected]> --------- Signed-off-by: gaobinlong <[email protected]> (cherry picked from commit 988a68a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
zane-neo
pushed a commit
to zane-neo/skills
that referenced
this pull request
Oct 11, 2024
…pensearch-project#423) * Fix CreateAnomalyDetectorTool doesn't support data streams and alias Signed-off-by: gaobinlong <[email protected]> * Refine the code comment Signed-off-by: gaobinlong <[email protected]> --------- Signed-off-by: gaobinlong <[email protected]> (cherry picked from commit 988a68a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
zane-neo
added a commit
that referenced
this pull request
Oct 11, 2024
* Fix test failure due to external change (#427) Signed-off-by: gaobinlong <[email protected]> * Fix CreateAnomalyDetectorTool doesn't support data streams and alias (#423) * Fix CreateAnomalyDetectorTool doesn't support data streams and alias Signed-off-by: gaobinlong <[email protected]> * Refine the code comment Signed-off-by: gaobinlong <[email protected]> --------- Signed-off-by: gaobinlong <[email protected]> (cherry picked from commit 988a68a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> --------- Signed-off-by: gaobinlong <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: gaobinlong <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
zane-neo
added a commit
that referenced
this pull request
Oct 11, 2024
…eams and alias (#425) * Fix CreateAnomalyDetectorTool doesn't support data streams and alias (#423) * Fix CreateAnomalyDetectorTool doesn't support data streams and alias Signed-off-by: gaobinlong <[email protected]> * Refine the code comment Signed-off-by: gaobinlong <[email protected]> --------- Signed-off-by: gaobinlong <[email protected]> (cherry picked from commit 988a68a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Backport/backport 423 to 2.x (#428) * Fix test failure due to external change (#427) Signed-off-by: gaobinlong <[email protected]> * Fix CreateAnomalyDetectorTool doesn't support data streams and alias (#423) * Fix CreateAnomalyDetectorTool doesn't support data streams and alias Signed-off-by: gaobinlong <[email protected]> * Refine the code comment Signed-off-by: gaobinlong <[email protected]> --------- Signed-off-by: gaobinlong <[email protected]> (cherry picked from commit 988a68a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> --------- Signed-off-by: gaobinlong <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: gaobinlong <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> --------- Signed-off-by: gaobinlong <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: zane-neo <[email protected]> Co-authored-by: gaobinlong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the bug of CreateAnomalyDetectorTool doesn't support data streams and alias, when calling with a data stream or alias, that tool throws
null_pointer_exceptionbecause the name of data stream or alias is not the key of the mapping, we should use a concrete index name to get the mapping.Related Issues
#337
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.