fix: read http entity only once in integ test #94
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In main and 2.x we use different http dependency in integ test. In main the dependency is from org.apache.hc.core5.http, and in 2.x it's from org.apache.http.
Current integ test code in main works well, but in 2.x, we can not read a http entity twice. The entity is a stream, if read twice, the result is null. We can solve this by cache the result and read it only once 28bfc01.
Although in main it works well, we can also modify this to keep it consistent between main and 2.x. If we modify some code in the future, this issue will not be a blocker for auto backport.
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.