Adding semantic check for missing arguments in function and unit test.

Signed-off-by: forestmvey <[email protected]>
opensearch-project · Jun 27, 2023 · de77277 · de77277
1 parent 84fab78
commit de77277
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/...rch/src/main/java/org/opensearch/sql/opensearch/storage/script/sort/SortQueryBuilder.java b/...rch/src/main/java/org/opensearch/sql/opensearch/storage/script/sort/SortQueryBuilder.java
@@ -80,7 +80,7 @@ public SortBuilder<?> build(Expression expression, Sort.SortOption option) {
    * @param nestedFunc Nested function expression.
    */
   private void validateNestedArgs(FunctionExpression nestedFunc) {
-    if (nestedFunc.getArguments().size() > 2) {
+    if (nestedFunc.getArguments().size() < 1 || nestedFunc.getArguments().size() > 2) {
       throw new IllegalArgumentException(
           "nested function supports 2 parameters (field, path) or 1 parameter (field)"
       );

diff --git a/...src/test/java/org/opensearch/sql/opensearch/storage/script/sort/SortQueryBuilderTest.java b/...src/test/java/org/opensearch/sql/opensearch/storage/script/sort/SortQueryBuilderTest.java
@@ -63,6 +63,17 @@ void nested_with_too_many_args_throws_exception() {
     );
   }
 
+  @Test
+  void nested_with_too_few_args_throws_exception() {
+    assertThrows(
+        IllegalArgumentException.class,
+        () -> sortQueryBuilder.build(
+            DSL.nested(),
+            Sort.SortOption.DEFAULT_ASC
+        )
+    );
+  }
+
   @Test
   void nested_with_invalid_arg_type_throws_exception() {
     assertThrows(