Skip to content

Commit

Permalink
Remove explicit node version for workbench (#588) (#589)
Browse files Browse the repository at this point in the history
Signed-off-by: Joshua Li <[email protected]>
(cherry picked from commit a7d4395)

Co-authored-by: Joshua Li <[email protected]>
  • Loading branch information
opensearch-trigger-bot[bot] and joshuali925 authored Apr 25, 2022
1 parent 40f881e commit eb65d2d
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 6 deletions.
5 changes: 3 additions & 2 deletions .github/workflows/sql-workbench-test-and-build-workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,10 @@ jobs:
path: sql/OpenSearch-Dashboards

- name: Setup Node
uses: actions/setup-node@v1
uses: actions/setup-node@v2
with:
node-version: '14.18.2'
node-version-file: "./OpenSearch-Dashboards/.nvmrc"
registry-url: 'https://registry.npmjs.org'

- name: Move Workbench to Plugins Dir
run: |
Expand Down
4 changes: 0 additions & 4 deletions workbench/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,6 @@
"tslint-config-prettier": "^1.18.0",
"tslint-plugin-prettier": "^2.0.1"
},
"engines": {
"node": "14.18.2",
"yarn": "^1.21.1"
},
"resolutions": {
"**/@types/node": "10.12.27",
"@types/react": "16.3.14",
Expand Down

0 comments on commit eb65d2d

Please sign in to comment.