Revert "Guarantee datasource read api is strong consistent read (#1815)" #2013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dreamer-89
requested review from
pjfitzgibbons,
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsi-amazon,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
Yury-Fridlyand,
anirudha,
forestmvey,
acarbonetto and
GumpacG
as code owners
…search-project#1815)" This reverts commit f38ffed. Signed-off-by: Suraj Singh <[email protected]>
dreamer-89
force-pushed
the
revert_1815
branch
from
ff48c59
to
9c17fcd
Compare
Codecov Report
@@ Coverage Diff @@
## main #2013 +/- ##
============================================
- Coverage 97.30% 97.30% -0.01%
Complexity 4623 4623
============================================
Files 407 407
Lines 11935 11934 -1
Branches 828 828
============================================
- Hits 11613 11612 -1
Misses 315 315
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Yury-Fridlyand
approved these changes
Aug 22, 2023
MaxKsyunz
approved these changes
Aug 24, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 24, 2023
…" (#2013) This reverts commit f38ffed. Signed-off-by: Suraj Singh <[email protected]> (cherry picked from commit 627189b) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
vamsi-amazon
pushed a commit
that referenced
this pull request
Sep 1, 2023
…" (#2013) (#2031) This reverts commit f38ffed. (cherry picked from commit 627189b) Signed-off-by: Suraj Singh <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit f38ffed.
Description
This change reverts the commit f38ffed as
_primarybased routing preference in order to reduce load on primary.match_all&termbased search queries which does not provide strong reads and thus as part of Compatibility with segment replication #1801 there was no need to perform_primarybased routing.Issues Resolved
Relates: #1801
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.