Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Disable join types in validators #3060

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport ac8678c from #3056.

* Disable join types in validators

Signed-off-by: Tomoyuki Morita <[email protected]>

* Removed methods from SQLQueryValidationVisitor due to grammar file change

Signed-off-by: Tomoyuki Morita <[email protected]>

---------

Signed-off-by: Tomoyuki Morita <[email protected]>
(cherry picked from commit ac8678c)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.48%. Comparing base (724176c) to head (7fb59f3).
Report is 1 commits behind head on 2.x.

Additional details and impacted files
@@             Coverage Diff              @@
##                2.x    #3060      +/-   ##
============================================
- Coverage     94.48%   94.48%   -0.01%     
+ Complexity     5419     5415       -4     
============================================
  Files           528      528              
  Lines         15444    15436       -8     
  Branches       1010     1010              
============================================
- Hits          14593    14585       -8     
  Misses          804      804              
  Partials         47       47              
Flag Coverage Δ
sql-engine 94.48% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ykmr1224 ykmr1224 merged commit 34a5fe5 into 2.x Oct 9, 2024
25 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants