Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-ISSUE: Move @patternfly dependencies to peerDependencies to avoid problems when using assisted-installer-app #2621

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ammont82
Copy link
Contributor

Testing assisted-installer-app we saw that yhe dependencies have to be deduplicated.
By pinning dependencies this will mess up the dependency deduplication
This should not be used in libraries but only in the actually apps.
One solution is to make these dependencies as peer dependencies so they are not installed with priority.

@ammont82 ammont82 requested a review from a team as a code owner June 26, 2024 12:54
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 26, 2024
@openshift-ci-robot
Copy link

@ammont82: This pull request explicitly references no jira issue.

In response to this:

Testing assisted-installer-app we saw that yhe dependencies have to be deduplicated.
By pinning dependencies this will mess up the dependency deduplication
This should not be used in libraries but only in the actually apps.
One solution is to make these dependencies as peer dependencies so they are not installed with priority.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jun 26, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 27, 2024
Copy link

openshift-ci bot commented Jun 27, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ammont82, jgyselov

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 3, 2024
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants