Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support console unmanaged mode #2950

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Support console unmanaged mode #2950

wants to merge 1 commit into from
+1 −1

Conversation

skonto
Copy link
Contributor

@skonto skonto commented Oct 16, 2024 •
edited
Loading

Fixes JIRA #

Proposed Changes

  • User install its own console in "Umanaged" mode, see possible values for managementState here. This will stop deploying the dashboards as the cluster operator status becomes:
  - lastTransitionTime: "2024-10-16T05:47:10Z"
    reason: Unmanaged
    status: Unknown
    type: Available

We currently expect this to be true.

  • See discussion here.

@skonto skonto force-pushed the fix_console_status_predicate branch from 0d9ff6e to 24a423b Compare October 16, 2024 09:32
@skonto
Copy link
Contributor Author

skonto commented Oct 16, 2024 •
edited
Loading

Should we cherry-pick for 1.34 as it supports 1.34? 🤔

@skonto skonto force-pushed the fix_console_status_predicate branch from 24a423b to 6165bc0 Compare October 16, 2024 09:35
@pierDipi
Copy link
Member

Should we cherry-pick for 1.34 as it supports 1.34? 🤔

I think we can and release it in the future

pierDipi
pierDipi approved these changes Oct 16, 2024
View reviewed changes
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm label Oct 16, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierDipi, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pierDipi
Copy link
Member

/cherry-pick release-1.34

@skonto
Copy link
Contributor Author

skonto commented Oct 16, 2024 •
edited
Loading

/hold is this a mode that we support for the product? Is console supported under this mode thus our dashboards are supported? Thus should we enable it anyway or not? cc @dsimansk @cardil

@openshift-cherrypick-robot
Copy link
Contributor

@pierDipi: once the present PR merges, I will cherry-pick it on top of release-1.34 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.34

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dsimansk
Copy link
Contributor

ACK it makes sense to work with Unmanaged state.

@ReToCode
Copy link
Member

LGTM, feel free to unhold

@skonto
Copy link
Contributor Author

skonto commented Oct 18, 2024

/retest

@skonto
Copy link
Contributor Author

skonto commented Oct 18, 2024

/unhold

@skonto
Copy link
Contributor Author

skonto commented Oct 18, 2024

/override ?

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 18, 2024

@skonto: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • ?

Only the following failed contexts/checkruns were expected:

  • Red Hat Konflux / serverless-operator-135-enterprise-contract / pr group fix_console_status_predicate
  • Red Hat Konflux / serverless-operator-135-enterprise-contract / serverless-ingress-135
  • Red Hat Konflux / serverless-operator-135-enterprise-contract / serverless-kn-operator-135
  • Red Hat Konflux / serverless-operator-135-enterprise-contract / serverless-metadata-webhook-135
  • Red Hat Konflux / serverless-operator-135-enterprise-contract / serverless-openshift-kn-operator-135
  • Update deps
  • ci/prow/416-images
  • ci/prow/416-operator-e2e-aws-416
  • ci/prow/416-test-upgrade-aws-416
  • ci/prow/416-upstream-e2e-aws-416
  • ci/prow/416-upstream-e2e-kafka-aws-416
  • code/snyk (Hybrid Platforms - OpenShift Serverless)
  • license/snyk (Hybrid Platforms - OpenShift Serverless)
  • pull-ci-openshift-knative-serverless-operator-main-416-images
  • pull-ci-openshift-knative-serverless-operator-main-416-operator-e2e-aws-416
  • pull-ci-openshift-knative-serverless-operator-main-416-test-upgrade-aws-416
  • pull-ci-openshift-knative-serverless-operator-main-416-upstream-e2e-aws-416
  • pull-ci-openshift-knative-serverless-operator-main-416-upstream-e2e-kafka-aws-416
  • security/snyk (Hybrid Platforms - OpenShift Serverless)
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@skonto
Copy link
Contributor Author

skonto commented Oct 18, 2024

/override "Red Hat Konflux / serverless-operator-135-enterprise-contract / pr group fix_console_status_predicate"
/override "Red Hat Konflux / serverless-operator-135-enterprise-contract / serverless-ingress-135"
/override "Red Hat Konflux / serverless-operator-135-enterprise-contract / serverless-kn-operator-135"
/override "Red Hat Konflux / serverless-operator-135-enterprise-contract / serverless-metadata-webhook-135"
/override "Red Hat Konflux / serverless-operator-135-enterprise-contract / serverless-openshift-kn-operator-135"

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 18, 2024

@skonto: Overrode contexts on behalf of skonto: Red Hat Konflux / serverless-operator-135-enterprise-contract / pr group fix_console_status_predicate, Red Hat Konflux / serverless-operator-135-enterprise-contract / serverless-ingress-135, Red Hat Konflux / serverless-operator-135-enterprise-contract / serverless-kn-operator-135, Red Hat Konflux / serverless-operator-135-enterprise-contract / serverless-metadata-webhook-135, Red Hat Konflux / serverless-operator-135-enterprise-contract / serverless-openshift-kn-operator-135

In response to this:

/override "Red Hat Konflux / serverless-operator-135-enterprise-contract / pr group fix_console_status_predicate"
/override "Red Hat Konflux / serverless-operator-135-enterprise-contract / serverless-ingress-135"
/override "Red Hat Konflux / serverless-operator-135-enterprise-contract / serverless-kn-operator-135"
/override "Red Hat Konflux / serverless-operator-135-enterprise-contract / serverless-metadata-webhook-135"
/override "Red Hat Konflux / serverless-operator-135-enterprise-contract / serverless-openshift-kn-operator-135"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 18, 2024

@skonto: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/416-test-upgrade-aws-416 6165bc0 link true /test 416-test-upgrade-aws-416

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 9a59043 and 2 for PR HEAD 6165bc0 in total

@skonto
Copy link
Contributor Author

skonto commented Oct 18, 2024

/test 416-test-upgrade-aws-416

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierDipi pierDipi pierDipi approved these changes

@creydr creydr Awaiting requested review from creydr

Assignees

@pierDipi pierDipi

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@skonto @pierDipi @openshift-cherrypick-robot @dsimansk @ReToCode @openshift-ci-robot